Repository navigation
[6.42] [eve7] GlViewerRCore: locate REve files from the server's importmap - #24058
Merged
dpiparo merged 1 commit intoNov 10, 2026
Merged
Conversation
The server's top directory was derived by cutting "jsrootsys/" off JSROOT's source_dir. With builtin_jsroot=OFF, the default since 018be76, JSROOT comes from root.cern, so RenderCore and the other REve files were requested from there, blocked by CORS, and the GL view stayed empty. Take it from the "rootui5sys/" entry of the importmap that THttpServer writes into the page. Keep the old rule for pages without an importmap. Assisted-by: claude-code:claude-opus-5-5 (cherry picked from commit d8b3123)
1 of 2 tasks
Test Results 24 files 24 suites 4d 3h 1m 0s ⏱️ For more details on these failures, see this check. Results for commit 4e827d7. |
dpiparo
merged commit Nov 10, 2026
7f2f9b3
into
root-project:v6-42-00-patches
33 of 36 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #24047, requested by @linev. For your information @alja