Repository navigation
[ntuple] Fix page checksum handling during recompression - #24147
Open
Johnny-Kao wants to merge 2 commits into
Open
Johnny-Kao wants to merge 2 commits into
Johnny-Kao wants to merge 2 commits into
Conversation
Johnny-Kao
marked this pull request as ready for review
November 13, 2026 17:13
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for the previous PR. Appreciated.
Second time here.
Would need your review on the following.
Changes
Merging RNTuples with different page checksum and compression settings can abort or crash when a page needs to be recompressed.
The merger allocates space using the source page's checksum setting, but calculates the recompressed page's size using the destination setting. When these differ, the size and checksum flag no longer agree.
This keeps the checksum size consistent with the source page, as in the existing fast-merge path.
It's related to #24085, but separate: that PR handled same-page merging without checksums; this fixes the recompression path.
I've also added a regression test for mixed settings in both source orders.
Testing:
Research run: https://github.com/Johnny-Kao/root-rntuple-research/actions/runs/43455000906
Checklist: