You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Neither colcon test nor Jenkins report warnings coming from Python code. For example, deprecated API was recently introduced in ros2/ros2cli#463 but CI passes without reported the warnings. I would expect an unstable build so that we notice things like deprecated Python APIs and can address them.
Specifically for tests, I tried passing a pytest argument to treat warnings as errors (#416), but this results in a failed build, instead of unstable, which I think is not desired.
Current aim is to try and figure out whether the existing Jenkins plugins can be configured to pick up python warnings in stderr (e.g. using a regex) or if a custom plugin will be required.
I did some checking and it doesn't appear that a python warning parser exists as part of the Jenkins analysis-model nor is there a separate plugin which provides one. I did manage to write a regexp-based parser to extract Python warnings from Pytest warnings summaries from colcon test stderr logs.
#447 is a PR which adds a parser for the warnings as they appear in our colcon logs.
Activity
hidmic commentedon Apr 8, 2020
@jacobperron were you able to make Jenkins pick up those warnings?
jacobperron commentedon Apr 8, 2020
@hidmic No, I didn't look into it too deeply.
hidmic commentedon May 4, 2020
Current aim is to try and figure out whether the existing Jenkins plugins can be configured to pick up python warnings in
stderr(e.g. using a regex) or if a custom plugin will be required.nuclearsandwich commentedon May 6, 2020
I did some checking and it doesn't appear that a python warning parser exists as part of the Jenkins analysis-model nor is there a separate plugin which provides one. I did manage to write a regexp-based parser to extract Python warnings from Pytest warnings summaries from colcon test stderr logs.
#447 is a PR which adds a parser for the warnings as they appear in our colcon logs.
dirk-thomas commentedon Aug 28, 2020
The
pytestwarnings are being redirected tostderrsince colcon/colcon-core#338. This is matching the behavior of e.g. C++ compiler warnings.It is up to Jenkins to extract those and change the build status based on it. See #509 for a draft PR doing that.