Skip to content

Python warnings are not reported by CI #418

Open

Description

@jacobperron

Neither colcon test nor Jenkins report warnings coming from Python code. For example, deprecated API was recently introduced in ros2/ros2cli#463 but CI passes without reported the warnings. I would expect an unstable build so that we notice things like deprecated Python APIs and can address them.

Here is an example build testing ros2node: Build Status

It is unstable for a different reason. The point is there are 61 warnings visible in the console, but they are not reported by Jenkins: https://ci.ros2.org/job/ci_linux/9731/consoleFull#console-section-223

Specifically for tests, I tried passing a pytest argument to treat warnings as errors (#416), but this results in a failed build, instead of unstable, which I think is not desired.

Related colcon PR to report pytest warnings: colcon/colcon-core#236

Activity

  1. removed their assignment
    on Apr 2, 2020
  2. hidmic commented on Apr 8, 2020

    @hidmic

    @jacobperron were you able to make Jenkins pick up those warnings?

  3. jacobperron commented on Apr 8, 2020

    @jacobperron
    MemberAuthor

    @hidmic No, I didn't look into it too deeply.

  4. hidmic commented on May 4, 2020

    @hidmic

    Current aim is to try and figure out whether the existing Jenkins plugins can be configured to pick up python warnings in stderr (e.g. using a regex) or if a custom plugin will be required.

  5. nuclearsandwich commented on May 6, 2020

    @nuclearsandwich
    Member

    I did some checking and it doesn't appear that a python warning parser exists as part of the Jenkins analysis-model nor is there a separate plugin which provides one. I did manage to write a regexp-based parser to extract Python warnings from Pytest warnings summaries from colcon test stderr logs.

    #447 is a PR which adds a parser for the warnings as they appear in our colcon logs.

  6. dirk-thomas commented on Aug 28, 2020

    @dirk-thomas
    Member

    Neither colcon test nor Jenkins report warnings coming from Python code.

    The pytest warnings are being redirected to stderr since colcon/colcon-core#338. This is matching the behavior of e.g. C++ compiler warnings.

    It is up to Jenkins to extract those and change the build status based on it. See #509 for a draft PR doing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions