Repository navigation
Switching to example_interfaces - #674
Conversation
Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with green CI
| // (rclcpp::KeepLast(7) -> rclcpp::KeepAll() fails to compile) | ||
| rclcpp::QoS qos(rclcpp::KeepLast{7}); | ||
| pub_ = this->create_publisher<std_msgs::msg::String>("chatter", qos); | ||
| pub_ = this->create_publisher<example_interfaces::msg::String>("chatter", qos); |
There was a problem hiding this comment.
this should resolve ros2/examples#377 (comment)
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
|
Pulls: #674 |
|
Pulls: #674 |
|
Thank you for the PR! |
On Kilted the demo_nodes_cpp talker still publishes std_msgs/msg/String; example_interfaces/msg/String was only adopted on Rolling (ros2/demos#674). The backport of #440 (#443) switched this test's WaitForTopics subscription to example_interfaces, so the endpoints never match and the test times out on every RMW. launch_testing_examples already declares std_msgs as an exec_depend. Fixes #455 Signed-off-by: Yadunund Vijay <yadunund@gmail.com>
On Kilted the demo_nodes_cpp talker still publishes std_msgs/msg/String; example_interfaces/msg/String was only adopted on Rolling (ros2/demos#674). The backport of #440 (#443) switched this test's WaitForTopics subscription to example_interfaces, so the endpoints never match and the test times out on every RMW. launch_testing_examples already declares std_msgs as an exec_depend. Fixes #455 Signed-off-by: Yadunund Vijay <yadunund@gmail.com>
This pull request solves the
demosside of this ros2_documentation issue in which we switch fromstd_msgstoexample_interfacesbecause std_msgs was deprecated about 4 years ago.