Repository navigation
Conversation
An empty dict assigned to a namespace input vanished during value collection, so the graph body was called without the argument and the caller saw a missing-argument TypeError instead of the input check's missing-member report. - A namespace remembers that a dict was assigned to it, and _collect_values keeps it even when it collects to nothing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
==========================================
+ Coverage 89.68% 89.70% +0.02%
==========================================
Files 81 81
Lines 8984 8996 +12
==========================================
+ Hits 8057 8070 +13
+ Misses 927 926 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
elinscott
added a commit
to elinscott/node-graph
that referenced
this pull request
Aug 12, 2026
The stored-ref review's fuller report (arrived after the earlier merge and test commits) flagged a second shape of the same bug: a required namespace nested INSIDE an explicitly-assigned-empty parent used to survive collection too, via the same required-based keep_empty rule this branch dropped in favor of scinode#170's assigned-based one — visible as `"codes" in config` silently flipping False to True with no assignment to `codes` anywhere. Already fixed by dropping keep_empty; this commit only locks it in with a regression test, following the file's own established pattern of a module-level reporting graph body (a locally-nested one does not reliably share SEEN across the cloudpickle re-import). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The error is wrong: the caller passed
dataexplicitly; the error says they didn't.The mechanism:
TaskSocketNamespace._collect_valueskept a child namespace only if its collected dict was truthy, so an assigned-but-empty namespace was indistinguishable from a never-assigned one by the time the graph body was called.Changes
_explicitly_assigned, set by_set_socket_value), and_collect_valueskeeps it even when it collects to nothing — the body now receives{}.Testing
_collect_valueschange fails exactly the new test; the full suite passes (310) with it in place.