Repository navigation
Conversation
Nothing in node-graph or aiida-workgraph ever read self.graph_type; its only observed value was the "NORMAL" default. Drop the constructor argument, the attribute, and its slot in get_metadata()/to_dict(); from_dict() now discards a stored graph_type key instead of round-tripping it, so old serialized graphs still load. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
elinscott
marked this pull request as ready for review
August 26, 2026 16:47
elinscott
added a commit
to elinscott/aiida-workgraph
that referenced
this pull request
Aug 26, 2026
node-graph removes Graph.graph_type (scinode/node-graph#180), so the disjointness tripwire and the round-trip assertions still naming it failed against the rebased declared-metadata-keys branch. - bookkeeping keys are now graph_class, definition and pk - the legacy-payload fixture no longer seeds graph_type Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
=======================================
Coverage 89.68% 89.68%
=======================================
Files 81 81
Lines 8984 8990 +6
=======================================
+ Hits 8057 8063 +6
Misses 927 927 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
elinscott
added a commit
to elinscott/node-graph
that referenced
this pull request
Aug 27, 2026
elinsc-bot
added a commit
to elinscott/koopmans
that referenced
this pull request
Aug 27, 2026
The ozone and O₂ regression snapshots recorded graph_type: NORMAL, which the updated node-graph no longer writes into a graph's metadata, so both test_build_workgraph checks failed on that one line. - the two snapshots lose the graph_type line; nothing else moves - pairs with the patched update carrying scinode/node-graph#180 and #181 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
graph_typeis vestigial. It exists in exactly three places — theGraph.__init__argument (graph_type: str = "NORMAL"), themetadataslotto_dict()writes, and the read-back infrom_dict()— and nothing reads it. This PR removes all three;from_dict()discards the key when an older payload still carries it, so stored graphs keep loading.One test added (
test_from_dict_discards_stale_graph_type); suite 308 → 309 passed, 1 skipped.Closes #179