Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #184 +/- ##
==========================================
+ Coverage 89.68% 89.76% +0.08%
==========================================
Files 81 81
Lines 8984 9001 +17
==========================================
+ Hits 8057 8080 +23
+ Misses 927 921 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #183.
From my debugging, I think the issue is caused by the assumption in
links_from_dictthat the leaf socket in thesocket_pathis in a dynamic namespace, which is not always the case (see minimal example in the issue, which I also added as an additional test). This leads to an exception when it tries to assert that the parent of the leaf socket is a dynamic namespace. To fix this, we now first check if the leaf socket is not already in the parent namespace before trying to add it as a dynamic child. If the leaf socket is already present, we simply use it as the target.