[Femimat]

Contributor checklist

• This pull request is on a separate branch and not the main branch
• I have tested my code with the ./gradlew lintKotlin detekt test command as directed in the testing section of the contributing guide

---

Description

This PR adds a subtle grey shadow (#3F3F46) to the popup view that appears when users long-press keys with alternate characters (e.g., accented letters).
The shadow visually separates the popup from the keyboard, making it clearer that the view is layered above.
This update ensures consistent appearance across both light and dark themes.

Changes Made

Updated minikeyboard_background.xml to include shadow properties.
Adjusted layout styling in keyboard_popup_keyboard.xml.

Related issue

• closes Add shadow to alternate keys view #491

[github-actions]

Thank you for the pull request! ❤️

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

[github-actions]

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

• The linting, formatting and testing workflows within the PR checks do not indicate new errors in the files changed

  • Tests may need to be reran as they're at times not deterministic

• The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

[andrewtavis]

Hey @Femimat 👋 I'm realizing that I might have been confused by the plans for this. Would we be able to add a small shadow to the views that's similar to what's under the keys? The background color for the alternate keys view should be the same as they keyboard background color. It'd be good if we had a shadow under it so it's clear that it's above they keyboard interface :)

[Femimat]

Hi @andrewtavis, I understand better now. I’ll go over it and see how I can implement the design.

[andrewtavis]

Sounds good, @Femimat! Looking forward to the update 😊

[Femimat]

Hey @andrewtavis! I’ve updated the PR — please have a look when you get a chance.

[DeleMike]

Hi @Femimat!

Thanks for the input!

---

Please can you avoid hardcoded colors - please reference a named color resource (e.g. @color/popup_shadow_color) for theme consistency.

• The popup looks a bit flat — maybe we can consider adding creating a more natural “shadowed” effect.

Nice work!

[Femimat]

Hi @DeleMike!
I’ll go over it and see how I can implement the design. thanks for the feedback.

[DeleMike]

Thanks so much! And I'm looking forward to it :)

[angrezichatterbox]

@Femimat

Are you still working on this PR? If not We could make the necessary changes and merge in the PR.

[Femimat]

Hi @angrezichatterbox,
I’m no longer working on this PR, so please feel free to make the required changes and proceed with the merge.

[angrezichatterbox]

Hey @DeleMike and @andrewtavis

Could you suggest if any more changes have to be made. I have made the hardcoded color to be normal.

[andrewtavis]

@angrezichatterbox, I'm not sure what mini_keyboard_color (#3F3F46) is being used for. Let's shift this a bit so we can get it merged more quickly :) We need a visible distinction between the alternate keys view and the keyboard background of the keyboard. Let's forget about a shadow, but how about the alternate keys view is the same color as the special keys? That would make it slightly darker than the keyboard background color in light mode and slightly lighter than the keyboard background in dark mode :)

[angrezichatterbox]

@angrezichatterbox, I'm not sure what mini_keyboard_color (#3F3F46) is being used for. Let's shift this a bit so we can get it merged more quickly :) We need a visible distinction between the alternate keys view and the keyboard background of the keyboard. Let's forget about a shadow, but how about the alternate keys view is the same color as the special keys? That would make it slightly darker than the keyboard background color in light mode and slightly lighter than the keyboard background in dark mode :)

The alternative keys include the conjugate keys right. What all keys do they include. The conjugate keys are going to be completely remade to use XML so I could add it there.

[andrewtavis]

@angrezichatterbox: By alternate keys view I mean the view that pops up when you hold the a, o, u, etc keys that have accent characters. If we could change the color of that view to be the same as the special keys then this should be able to be closed. Any non-necessary changes to that could also be removed from this, but then I'm not sure if some of the current changes will be used other places 😊

Thanks for checking in on this! :)

[angrezichatterbox]

@angrezichatterbox: By alternate keys view I mean the view that pops up when you hold the a, o, u, etc keys that have accent characters. If we could change the color of that view to be the same as the special keys then this should be able to be closed. Any non-necessary changes to that could also be removed from this, but then I'm not sure if some of the current changes will be used other places 😊

Thanks for checking in on this! :)

It been long since I have worked on it so I got a little confused. I will get the fix ready in a while.

[angrezichatterbox]

Would this be fine ?

[angrezichatterbox]

The other colors blend in pretty well with the background of the keyboard.

[andrewtavis]

praise: Fix makes total sense, @angrezichatterbox! Looking at the special key color, I can see how that would similarly blend into the keyboard background. Maybe something for later would be removing the shadow for the keys in the view, but for now this is definitely a step in the right direction!

further praise: Thanks so much for taking this on, @Femimat, for the initial review, @DeleMike and for bringing this home, @angrezichatterbox! 🚀