Skip to content

Fix/string remove - #507

Merged
angrezichatterbox merged 6 commits into
scribe-org:mainfrom
omjamnekar:fix/string-remove
Nov 17, 2025
Merged

angrezichatterbox merged 6 commits into
scribe-org:mainfrom
omjamnekar:fix/string-remove

Conversation

@omjamnekar

Copy link
Copy Markdown
Contributor

Contributor checklist


Description

This pull request updates the strings.xml file by:

  • Cleaning up long multiline strings for safer XML parsing.
  • Maintaining readability and comments for better maintenance.
  • Removed editing inside Scrib-i18n subtree

Related issue

@github-actions

Copy link
Copy Markdown

Thank you for the pull request! 💙

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions

Copy link
Copy Markdown

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The linting, formatting and testing workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis

Copy link
Copy Markdown
Member

Thanks for opening another PR, @omjamnekar! We'll get to the review in the coming days :)

@angrezichatterbox angrezichatterbox left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great First PR @omjamnekar. Happy to see that a lot of the unnecessary strings have been removed. We would merge this once the workflows succeeds.

@angrezichatterbox angrezichatterbox linked an issue Nov 17, 2025 that may be closed by this pull request
2 tasks done
@angrezichatterbox
angrezichatterbox merged commit bd3ce04 into scribe-org:main Nov 17, 2025
6 checks passed
@andrewtavis

Copy link
Copy Markdown
Member

So great to have this in, @omjamnekar :) Thanks for the work, and also thanks for the support and review @angrezichatterbox! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unneeded strings from app/src/main/res/values/strings.xml

4 participants