Skip to content

ci: close the gaps in the Codecov upload - #1207

Merged
dkropachev merged 1 commit into
scylladb:scylla-4.xfrom
nikagra:ci/codecov-followups
Oct 6, 2026
Merged

dkropachev merged 1 commit into
scylladb:scylla-4.xfrom
nikagra:ci/codecov-followups

Conversation

@nikagra

@nikagra nikagra commented Oct 5, 2026 •

Copy link
Copy Markdown

The Codecov upload from #1162 can publish a partial report as the scylla-4.x baseline. It also fails green push runs in forks, and its percentage sits about 5.6 points below the job summary's.

  • Restore the "Check that every lane handed over execution data" step and require it in built.
  • Skip the upload job outside scylladb/java-driver.
  • codecov.yml: parsers.jacoco.partials_as_hits: true, at the cost of Codecov no longer marking half-tested branch lines as partial; fix the header's job name.
  • Set plugins: noop on the upload step, as in ci(coverage): upload the coverage profiles to Codecov gocql#1089.

Verification:

  • actionlint passes on tests@v1.yml, and Codecov's /validate accepts codecov.yml.
  • I ran the lane step's script on fixture directories: it exits 1 with an empty lane and 0 when every lane has data.
  • Applying Codecov's JaCoCo rule to the 3ecee01 report gives 76.23% by default and 81.79% with partials_as_hits, against JaCoCo's 81.81%.
  • This PR's Codecov comment will show about +5.6 points that no test added: the base report was processed under the old codecov.yml.
  • Not covered: the upload itself, which runs tokenless from a fork PR.

Fixes #1206

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: QUIET
  • Plan: Advanced
  • Run ID: cb15d882-b5b4-4bbf-be11-a5c810ac1068
📥 Commits

Reviewing files that changed from the base of the PR and between b74bc31 and 712b28f.

📒 Files selected for processing (3)
  • .github/workflows/tests@v1.yml
  • README-dev.md
  • codecov.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The workflow checks that each lane provides a nonempty .exec file before marking the report as built. The Codecov job runs only in scylladb/java-driver and disables plugin discovery. The Codecov configuration treats partially covered JaCoCo branch lines as hits. The README and configuration comments describe the upload conditions and job.

Suggested reviewers: roydahan

Priority: ➖ Normal

Change: Bug fix · Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to 712b2

The workflow gates uploads on successful tests and coverage data, and fork pull requests have a supported tokenless upload path. No material CI or coverage-upload issue is established; the PR is ready under normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the Codecov upload changes.
Description check ✅ Passed The description explains the Codecov changes and reported verification.
Linked Issues check ✅ Passed The change addresses all five coding requirements in #1206: it checks for lane execution data and gates built on that check, restricts the Codecov job to scylladb/java-driver, sets `partials_as_hi…
Out of Scope Changes check ✅ Passed The workflow, Codecov configuration, and README changes all support the fixes requested in #1206. No unrelated changes are reported.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Restore the per-lane execution data check that scylladb#1162's rewrite dropped,
so a lane passing without agent data no longer uploads a partial
baseline. Skip the upload outside scylladb/java-driver, count JaCoCo
partials as hits to match the job summary, turn off the CLI's
non-Java plugins and fix the stale job name in codecov.yml.

Fixes scylladb#1206

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@nikagra
nikagra force-pushed the ci/codecov-followups branch from 10b6c23 to 712b28f Compare October 6, 2026 13:31
@nikagra nikagra changed the title ci: restore the lane check and fix gaps in the Codecov upload ci: close the gaps in the Codecov upload Oct 6, 2026
@nikagra
nikagra requested review from dkropachev and roydahan and removed request for roydahan October 6, 2026 13:36
@nikagra
nikagra marked this pull request as ready for review October 6, 2026 13:37
@codecov

codecov Bot commented Oct 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.77%. Comparing base (bded626) to head (712b28f).
⚠️ Report is 4 commits behind head on scylla-4.x.

Additional details and impacted files
@@               Coverage Diff                @@
##             scylla-4.x    #1207      +/-   ##
================================================
+ Coverage         76.21%   81.77%   +5.56%     
+ Complexity         9691     9690       -1     
================================================
  Files               980      980              
  Lines             36684    36684              
  Branches           5048     5048              
================================================
+ Hits              27958    30000    +2042     
+ Misses             6686     6684       -2     
+ Partials           2040        0    -2040     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dkropachev
dkropachev merged commit af4e54b into scylladb:scylla-4.x Oct 6, 2026
33 checks passed
@nikagra
nikagra deleted the ci/codecov-followups branch October 6, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: close the gaps in the Codecov upload

2 participants