Repository navigation
ci: close the gaps in the Codecov upload - #1207
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe workflow checks that each lane provides a nonempty Suggested reviewers: Priority: ➖ Normal Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to The workflow gates uploads on successful tests and coverage data, and fork pull requests have a supported tokenless upload path. No material CI or coverage-upload issue is established; the PR is ready under normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Restore the per-lane execution data check that scylladb#1162's rewrite dropped, so a lane passing without agent data no longer uploads a partial baseline. Skip the upload outside scylladb/java-driver, count JaCoCo partials as hits to match the job summary, turn off the CLI's non-Java plugins and fix the stale job name in codecov.yml. Fixes scylladb#1206 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
10b6c23 to
712b28f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## scylla-4.x #1207 +/- ##
================================================
+ Coverage 76.21% 81.77% +5.56%
+ Complexity 9691 9690 -1
================================================
Files 980 980
Lines 36684 36684
Branches 5048 5048
================================================
+ Hits 27958 30000 +2042
+ Misses 6686 6684 -2
+ Partials 2040 0 -2040 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The Codecov upload from #1162 can publish a partial report as the
scylla-4.xbaseline. It also fails green push runs in forks, and its percentage sits about 5.6 points below the job summary's.built.scylladb/java-driver.codecov.yml:parsers.jacoco.partials_as_hits: true, at the cost of Codecov no longer marking half-tested branch lines as partial; fix the header's job name.plugins: noopon the upload step, as in ci(coverage): upload the coverage profiles to Codecov gocql#1089.Verification:
actionlintpasses ontests@v1.yml, and Codecov's/validateacceptscodecov.yml.3ecee01report gives 76.23% by default and 81.79% withpartials_as_hits, against JaCoCo's 81.81%.codecov.yml.Fixes #1206
🤖 Generated with Claude Code