Repository navigation
build: exclude BlockHound from Revapi analysis in core - #1284
Merged
dkropachev merged 1 commit intoOct 20, 2026
Merged
Conversation
BlockHound 1.0.17 (scylladb#1274) shades a ByteBuddy with new vararg overloads of ModifierContributor.Resolver::of. Revapi resolves provided dependencies and reports them, failing Full verify on scylla-4.x. BlockHound is provided scope and none of its API is the driver's. Fixes scylladb#1117 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
nikagra
marked this pull request as ready for review
October 20, 2026 16:12
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can open the rule or relationship behind a finding in one click Powered by Qodo |
dkropachev
approved these changes
Oct 20, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## scylla-4.x #1284 +/- ##
================================================
+ Coverage 84.79% 84.84% +0.04%
- Complexity 8625 8632 +7
================================================
Files 848 848
Lines 31033 31038 +5
Branches 4281 4282 +1
================================================
+ Hits 26315 26333 +18
+ Misses 4718 4705 -13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full verifyhas been red onscylla-4.xsince the BlockHound 1.0.17 bump (#1274, 9995335). The new release shades a ByteBuddy that addsModifierContributor.Resolver::of(ForModule...)vararg overloads. Revapi resolvesprovideddependencies, so it reports them as newvarargOverloadsOnlyDifferInVarargParameterproblems injava-driver-core. This also blocks unrelated PRs such as #1283.reactor\.blockhound(\..+)?to the package excludes incore/revapi.json, as build: exclude BlockHound from Revapi analysis in core #1117 proposed. BlockHound isprovidedand none of its API is the driver's. The only reference is the internalDriverBlockHoundIntegration, which is already excluded.Verified on JDK 11:
mvn -pl core -am install -DskipTests, thenmvn -pl core revapi:check. It fails with the 4 CI errors before the change and passes after. Other modules' Revapi checks were not run locally.Fixes #1117
🤖 Generated with Claude Code