Skip to content

build: exclude BlockHound from Revapi analysis in core - #1284

Merged
dkropachev merged 1 commit into
scylladb:scylla-4.xfrom
nikagra:revapi-exclude-blockhound
Oct 20, 2026
Merged

dkropachev merged 1 commit into
scylladb:scylla-4.xfrom
nikagra:revapi-exclude-blockhound

Conversation

@nikagra

@nikagra nikagra commented Oct 20, 2026

Copy link
Copy Markdown

Full verify has been red on scylla-4.x since the BlockHound 1.0.17 bump (#1274, 9995335). The new release shades a ByteBuddy that adds ModifierContributor.Resolver::of(ForModule...) vararg overloads. Revapi resolves provided dependencies, so it reports them as new varargOverloadsOnlyDifferInVarargParameter problems in java-driver-core. This also blocks unrelated PRs such as #1283.

Verified on JDK 11: mvn -pl core -am install -DskipTests, then mvn -pl core revapi:check. It fails with the 4 CI errors before the change and passes after. Other modules' Revapi checks were not run locally.

Fixes #1117

🤖 Generated with Claude Code

BlockHound 1.0.17 (scylladb#1274) shades a ByteBuddy with new vararg overloads
of ModifierContributor.Resolver::of. Revapi resolves provided
dependencies and reports them, failing Full verify on scylla-4.x.
BlockHound is provided scope and none of its API is the driver's.

Fixes scylladb#1117

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: QUIET
  • Plan: Essentials
  • Run ID: da1e832d-802a-4278-bb26-5f287128cdd2
📥 Commits

Reviewing files that changed from the base of the PR and between cb51063 and e7f4a3d.

📒 Files selected for processing: 1
  • core/revapi.json

Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

📝 Walkthrough

The Revapi package exclusion list now excludes reactor.blockhound and its subpackages.

Suggested reviewers: olim7t

Priority: ⬇️ Low

Change: Bug fix

Merge Risk: ⚪ Minimal · up to e7f4a

No actionable merge-blocking risk remains in this Revapi configuration change.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies the main change: excluding BlockHound from Revapi analysis in core.
Description check Passed The description explains the Revapi failures, the exclusion change, the rationale, and the verification performed.
Linked Issues check Passed Issue #1117 requires excluding BlockHound from core Revapi analysis. core/revapi.json now excludes reactor\\.blockhound(\\..+)?, which covers the package and subpackages. The change matches one acce…
Out of Scope Changes check Passed The whole-PR diff contains one scoped change in core/revapi.json: the BlockHound package exclusion. The change directly implements issue #1117. No unrelated source, dependency, or module changes are…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Linked Issues check

Explanation

Issue #1117 requires excluding BlockHound from core Revapi analysis. core/revapi.json now excludes reactor\.blockhound(\..+)?, which covers the package and subpackages. The change matches one accepted issue solution. No other active directly linked coding requirement applies.

Full details: Out of Scope Changes check

Explanation

The whole-PR diff contains one scoped change in core/revapi.json: the BlockHound package exclusion. The change directly implements issue #1117. No unrelated source, dependency, or module changes are present.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@nikagra
nikagra marked this pull request as ready for review October 20, 2026 16:12
@qodo-scylladb

qodo-scylladb Bot commented Oct 20, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review
Tip of the day
💡 Did you know, you can open the rule or relationship behind a finding in one click

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗


Powered by Qodo

@dkropachev
dkropachev merged commit dca3d75 into scylladb:scylla-4.x Oct 20, 2026
29 checks passed
@codecov

codecov Bot commented Oct 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.84%. Comparing base (1409aec) to head (e7f4a3d).
⚠️ Report is 80 commits behind head on scylla-4.x.

Additional details and impacted files
@@               Coverage Diff                @@
##             scylla-4.x    #1284      +/-   ##
================================================
+ Coverage         84.79%   84.84%   +0.04%     
- Complexity         8625     8632       +7     
================================================
  Files               848      848              
  Lines             31033    31038       +5     
  Branches           4281     4282       +1     
================================================
+ Hits              26315    26333      +18     
+ Misses             4718     4705      -13     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build: exclude BlockHound from Revapi analysis in core

2 participants