Skip to content

fix(ci): keep commas out of release-blocker links - #1336

Merged
dkropachev merged 1 commit into
scylladb:scylla-4.xfrom
nikagra:blocker-link-commas-4.x
Oct 28, 2026
Merged

dkropachev merged 1 commit into
scylladb:scylla-4.xfrom
nikagra:blocker-link-commas-4.x

Conversation

@nikagra

@nikagra nikagra commented Oct 28, 2026 •

Copy link
Copy Markdown

The release blocker check printed issue URLs separated by , . Browsers then linkified the comma into the first URL, and GitHub redirected …/issues/1297, to …/issues/created_by/1297, (seen in release run 40622434506).

  • target.py blockers prints one URL per line, with nothing attached
  • New test_blocker_message_keeps_links_bare checks the message lines are exactly the URLs

Same change on both release lines: this PR targets scylla-4.x, #1335 is its twin on scylla-3.x.

Verified with python3 -m unittest discover -s scripts/release -p 'test_*.py' (all pass) and python3 scripts/release/guard.py check. Reverting the separator makes the new test fail.

🤖 Generated with Claude Code

The blocker check listed issue URLs comma-separated, and browsers
linkified the trailing comma into the first URL, which GitHub then
redirected to a wrong page. Print one URL per line instead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit c6b7ff5)
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: QUIET
  • Plan: Essentials
  • Run ID: 6194af78-26a3-43c1-ac76-fcc9e996664d
Commits

Reviewing files that changed from the base of the PR and between 8673cc8 and deea275.

Files selected for processing: 2
  • scripts/release/target.py
  • scripts/release/test_target.py

Included review availability: This review used your included allowance. 2 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

Walkthrough

The blocker error message now lists each matching issue URL on a separate line. A test checks that the URLs remain unchanged and in input order.

Possibly related PRs

Priority: Low

Change: Bug fix

Merge Risk: Minimal · up to deea2

The blocker URLs are now emitted as bare, separate lines, with coverage for ordering and formatting.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly describes the main change: removing commas from release-blocker links.
Description check Passed The description accurately explains the URL-linking issue, the code and test changes, and the reported validation results.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 2 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@nikagra
nikagra requested a review from dkropachev October 28, 2026 15:42
@nikagra
nikagra marked this pull request as ready for review October 28, 2026 15:42
@qodo-scylladb

qodo-scylladb Bot commented Oct 28, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review
Tip of the day
💡 Did you know, you can turn on the rule miner and Qodo learns your standards from review history

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗


Powered by Qodo

@codecov

codecov Bot commented Oct 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.87%. Comparing base (8673cc8) to head (deea275).

Additional details and impacted files
@@               Coverage Diff                @@
##             scylla-4.x    #1336      +/-   ##
================================================
+ Coverage         84.85%   84.87%   +0.01%     
- Complexity         8641     8647       +6     
================================================
  Files               851      851              
  Lines             31056    31056              
  Branches           4282     4282              
================================================
+ Hits              26353    26359       +6     
+ Misses             4703     4697       -6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dkropachev
dkropachev merged commit 1c34f48 into scylladb:scylla-4.x Oct 28, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants