Repository navigation
fix(create-sei): bump the template to next 15.5.28 and sharp 0.35.5 - #355
Conversation
Five advisories published since October 6 cover the template's pinned next@15.5.25 and its sharp@0.35.4 override, so every generated app installed them. The worst is GHSA-2464-fhr4-w9xw, a critical unauthenticated RCE in Next's Image Optimization API. next 15.5.28 clears the four Next advisories and sharp 0.35.5 clears the librsvg one, both inside their pinned minors. Next 15.5.28 declares Sharp ^0.34.3 || ^0.35.5, so the image notes in the template README and next.config.mjs now name 0.35.5 as the advisory floor: the 0.34.x half of that range is inside both Sharp advisories. Co-authored-by: Cursor <cursoragent@cursor.com>
PR SummaryLow Risk Overview
Reviewed by Cursor Bugbot for commit 883362a. Bugbot is set up for automated code reviews on this repo. Configure here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #355 +/- ##
=======================================
Coverage 97.82% 97.82%
=======================================
Files 81 81
Lines 5652 5652
=======================================
Hits 5529 5529
Misses 123 123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
This is a narrow security bump of the Next template: next goes from 15.5.25 to 15.5.28 and the sharp override from 0.35.4 to 0.35.5. The README and next.config.mjs notes are updated to match, and a @sei-js/create-sei patch changeset is included. Nothing stale remains in the template, and I found no correctness issues.
Findings: 0 blocking | 3 non-blocking | 0 posted inline
Blockers
- None at the file/PR level.
Non-blocking
- The Cursor review file (
cursor-review.md) was empty, so that pass produced no output. Codex found no material issues, and I agree. - I could not check the advisory IDs, CVE-2026-96889, or Next 15.5.28's Sharp declaration (
^0.34.3 || ^0.35.5) from the diff alone. The changeset and docs repeat these details, so a reviewer should open the linked GHSA pages before merge to confirm the version ranges are correct. - I searched
packages/create-seifor leftover15.5.25or0.35.4pins and found none outside the historical CHANGELOG entries. Thesharpoverride still sits inside the Sharp range Next declares.
Five advisories published since October 6 cover the Next template's pinned
next@15.5.25and itssharp@0.35.4override, so every appcreate-seigenerates installs them. The worst is GHSA-2464-fhr4-w9xw, a critical unauthenticated RCE in Next's Image Optimization API, published yesterday.GHSA-2464-fhr4-w9xw— critical, unauthenticated RCE in the Image Optimization API,next>=10.0.0 <=15.5.27.GHSA-p3m5-59mp-jv5r— high, App Router denial of service through Server Actions,next>=13.0.0 <=15.5.27.GHSA-mcj8-r9mp-w47pandGHSA-4jqv-mc3x-m676— moderate, SSG and ISR cache poisoning,next>=15.0.0 <15.5.27.GHSA-wq5f-xc86-pv6w— high, a memory bug in Sharp's bundled librsvg (CVE-2026-96889) that can lead to RCE on glibc-based Linux,sharp<0.35.5.Changes
nextfrom15.5.25to15.5.28and itssharpoverride from0.35.4to0.35.5, both inside their pinned minors.^0.34.3 || ^0.35.5, so the image notes in the template README andnext.config.mjsnow name0.35.5as the advisory floor. The0.34.xhalf of that range is inside both Sharp advisories.@sei-js/create-seipatch changeset.Merge order
The Sei Global Wallet Consumer Smoke runs here because the PR adds a changeset, and it fails on the
sharpdrift that #356 fixes, the same failuremainhas had since October 6. Merge #356 first, then rebase this.Verification
bun run test:create-sei-releasepasses locally on Bun 1.3.14, the versionmainpins.autoselects registry mode on this branch, where the audit is report-only. Both variants now report only the existing moderatedecode-uri-componentfinding, down from 1 critical, 2 high, and 3 moderate onmain.bun run checkand thecreate-seiunit tests pass.No published dependency or peer range changes.