Repository navigation
refactor(cli): Rename approximations to models - #382
Merged
Merged
Conversation
Saloed
approved these changes
Aug 26, 2026
misonijnik
force-pushed
the
misonijnik/go-models-cli
branch
from
August 29, 2026 15:53
b79c10c to
be0a69d
Compare
misonijnik
force-pushed
the
misonijnik/go-models-cli
branch
from
September 2, 2026 09:31
be0a69d to
8d2bd18
Compare
misonijnik
force-pushed
the
misonijnik/go-models-cli
branch
from
September 2, 2026 09:32
8d2bd18 to
bdf7868
Compare
misonijnik
force-pushed
the
misonijnik/go-models-cli
branch
from
September 2, 2026 15:35
bdf7868 to
4a9bea4
Compare
misonijnik
force-pushed
the
misonijnik/go-models-cli
branch
from
September 2, 2026 16:10
4a9bea4 to
045221a
Compare
misonijnik
force-pushed
the
misonijnik/go-models-cli
branch
from
September 5, 2026 11:40
045221a to
494af06
Compare
misonijnik
changed the title
misonijnik
changed the title
misonijnik
force-pushed
the
misonijnik/go-models-cli
branch
from
October 13, 2026 10:31
494af06 to
6b539fb
Compare
misonijnik
force-pushed
the
misonijnik/go-models-cli
branch
from
October 13, 2026 12:33
6b539fb to
8709418
Compare
misonijnik
force-pushed
the
misonijnik/go-models-cli
branch
2 times, most recently
from
October 27, 2026 11:25
517feb7 to
b663f88
Compare
misonijnik
force-pushed
the
misonijnik/go-models-cli
branch
from
October 27, 2026 12:18
b663f88 to
be28ef9
Compare
misonijnik
force-pushed
the
misonijnik/go-models-cli
branch
from
October 27, 2026 21:10
be28ef9 to
3bf09dd
Compare
misonijnik
force-pushed
the
misonijnik/go-models-cli
branch
from
October 28, 2026 09:23
3bf09dd to
df0c52b
Compare
The commands are now model init, compile models, and test model init and run, and the flags are --dataflow-models and --passthrough-models. The old names stay as hidden aliases that print a deprecation notice and run the new command or set the new flag.
The packages are now internal/models and internal/testmodel, and the command files follow the command names. The harness rule of model tests is model-rule.yaml#model-rule, the test project is model-test-project, and the Gradle project of a model project is dependency-models. Messages say model instead of approximation. The approximation.yaml descriptor and the approximations API jar keep their names.
A model test can now apply pass-through models next to the dataflow models under test, as test rule run already does.
Gr-i-niy
force-pushed
the
misonijnik/go-models-cli
branch
from
November 2, 2026 12:19
c99ece9 to
c3be33d
Compare
An unhandled analyzer exception (exit code 252) is only described in the analyzer log, which lives in a temporary directory. test rule run and test model run now print its path. scan already points at its own log file, which holds the analyzer output, so it prints the analyzer log only when it has no log file.
Gr-i-niy
force-pushed
the
misonijnik/go-models-cli
branch
from
November 2, 2026 12:39
c3be33d to
5bfff95
Compare
Gr-i-niy
approved these changes
Nov 2, 2026
Gr-i-niy
changed the title
Saloed
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.