[AndyBlack]

This adds three options to the Use PcPatr with FLEx utility dialog. The first option is what we have been using. The two new ones are for debugging a PC-PATR grammar. When a user clicks on either of the two new options, they will flash red as a warning to be careful when using these. They change the content of the PcPatrFLEx.tak file.

It adds four new items to the PCPATR custom list.

The change also includes enhancements to the user documentation, including a new reference web page.

---

This change is 

[github-actions]

NUnit Tests

    1 files  ±0      1 suites  ±0   11m 5s ⏱️ - 3m 7s
7 058 tests +1  6 973 ✅ +1  85 💤 ±0  0 ❌ ±0 
7 067 runs  +1  6 982 ✅ +1  85 💤 ±0  0 ❌ ±0 

Results for commit 5e6b173. ± Comparison against base commit 412ee26.

♻️ This comment has been updated with latest results.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 40.52%. Comparing base (c734bff) to head (5e6b173).
⚠️ Report is 25 commits behind head on main.

Files with missing lines	Patch %	Lines
...s/pcpatrflex/DisambiguateInFLExDB/PCPatrInvoker.cs	93.75%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1237      +/-   ##
==========================================
+ Coverage   39.93%   40.52%   +0.58%     
==========================================
  Files        1542     1559      +17     
  Lines      355165   356108     +943     
  Branches    41317    41590     +273     
==========================================
+ Hits       141833   144297    +2464     
+ Misses     183999   182498    -1501     
+ Partials    29333    29313      -20     

Files with missing lines	Coverage Δ
Src/Utilities/pcpatrflex/PrepFLExDBDll/Preparer.cs	98.13% <100.00%> (+0.02%)	⬆️
...s/pcpatrflex/DisambiguateInFLExDB/PCPatrInvoker.cs	93.96% <93.75%> (-0.21%)	⬇️

... and 115 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[thejambi]

Src/Utilities/pcpatrflex/PcPatrFLExDll/PcPatrFLExForm.cs line 137 at r1 (raw file):

						btnDisambiguate.Enabled = false;
					Cursor.Current = Cursors.Default;
					SetupFlashingTimer();

Clicking a Show Failures option crashes on first launch

SetupFlashingTimer() and UpdateShowFailuresChecked() are only called inside if (regkey != null). The registry key is only created when the form closes, in SaveRegistryInfo, so it doesn't exist the first time someone opens PcPatrFLEx.

On that first launch flashTimer stays null. Clicking any of the three Show Failures options runs UpdateShowFailuresValue, which calls flashTimer.Stop() or flashTimer.Start() and throws an unhandled NullReferenceException. The group also opens with no option selected, because UpdateShowFailuresChecked() is skipped too.

Suggested fix: move both calls out of the if block, for example just before AdjustSplitterLocation();:

}
SetupFlashingTimer();
UpdateShowFailuresChecked();
AdjustSplitterLocation();

[thejambi]

@thejambi reviewed 18 files and all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on AndyBlack).

[thejambi]

Src/Utilities/pcpatrflex/PcPatrFLExDll/PcPatrFLExForm.cs line 902 at r2 (raw file):

		private void SetupFlashingTimer()
		{
			flashTimer = new Timer();

Flash timer keeps running after the dialog closes

flashTimer is created with new Timer(). It isn't added to components, and nothing stops or disposes it when the form closes.

If PcPatrFLEx is closed while a debug option is selected, the timer keeps ticking inside the FLEx process. While it runs, it keeps the closed form in memory through its Tick handler. Each open-and-close in a debug mode leaves another form and timer behind.

Suggested fix: stop and dispose the timer in OnFormClosing:

private void OnFormClosing(object sender, EventArgs e)
{
	flashTimer?.Stop();
	flashTimer?.Dispose();
	SaveRegistryInfo();
}

[thejambi]

@thejambi reviewed 2 files and all commit messages, and resolved 3 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on AndyBlack).