Repository navigation
Bump the frontend to node 26 and install pnpm directly - #2574
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
💤 Files with no reviewable changes (2)
Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe frontend Docker images now use Node 26. Development builds install pnpm 10.24.0 directly. Installation tasks no longer enable Corepack. The setup guide links to pnpm installation documentation. ChangesFrontend toolchain
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The PR updates the frontend Node and pnpm setup and removes obsolete Corepack instructions; no actionable merge-blocking risk remains beyond normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
|
Why don't we change packages engine to 26 >= while we're at it, just so we're all on the same page |
Node 20 is EOL. Node 26 doesn't ship corepack, so the corepack lines went from working around an old corepack bug to being needed just to get corepack at all. pnpm reads the packageManager field itself, so install pnpm and drop the extra tool. That also drops the unpinned corepack@latest. `corepack enable || true` in the Taskfiles could never succeed on node 26, and the `|| true` hid it. The README told new devs to run `corepack enable`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
frontend/.npmrc sets engine-strict=true, so engines.node is a hard install gate rather than a warning. Raising it to >=26 lines the floor up with the docker images, and means everyone needs node 26 before it goes LTS on 2026-10-28. The workspace root's engines gates every install regardless of which directory pnpm runs from, and all three packages are private, so the viewer and https-proxy copies never did anything. pnpm floor goes to >=10 to match packageManager, and the README prerequisite is no longer true after this change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
37ae3c2 to
7745f15
Compare
Node 20 is EOL. Replaces #2522, which bumped the base images but left the corepack setup around them stale.
Node 25+ doesn't ship corepack, so
npm install -g corepack@lateststopped being a workaround for an old corepack bug and became the only way to get corepack at all. pnpm reads thepackageManagerfield itself, so it's simpler to install pnpm and drop the extra tool (and the unpinnedcorepack@latestwith it).The two dev-facing leftovers go too:
corepack enable || truein the Taskfiles could never succeed on node 26 and the|| truehid that, andfrontend/README.mdtold new devs to runcorepack enable.Not included on purpose: CI still resolves its node version from
engines.node, so it runs whatever the runner has cached (24.19.0 today) rather than 26. That divergence is pre-existing and worth its own PR.