Skip to content

Accept both options and OPTIONS in URLRequest method normalization - #141

Open
dfabulich wants to merge 1 commit into
skiptools:mainfrom
dfabulich:url-method-normalization-test-fix
Open

dfabulich wants to merge 1 commit into
skiptools:mainfrom
dfabulich:url-method-normalization-test-fix

Conversation

@dfabulich

Copy link
Copy Markdown
Member

macOS 27 now uppercases OPTIONS like GET/HEAD/POST, while macOS 26 still leaves lowercase "options" unchanged (#139).

Thank you for contributing to the Skip project! Please use this space to describe your change and add any labels (bug, enhancement, documentation, etc.) to help categorize your contribution.

Please review the contribution guide at https://skip.dev/docs/contributing/ for advice and guidance on making high-quality PRs.

Skip Pull Request Checklist:

  • REQUIRED: I have signed the Contributor Agreement
  • REQUIRED: I have tested my change locally with swift test
  • OPTIONAL: I have tested my change on an iOS simulator or device
  • OPTIONAL: I have tested my change on an Android emulator or device

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

The test passes now on macOS 27 on my machine; it should now pass in CI as well.

* Fixes skiptools#139

macOS 27 now uppercases OPTIONS like GET/HEAD/POST, while macOS 26 still leaves lowercase "options" unchanged (skiptools#139).
@cla-bot cla-bot Bot added the cla-signed label Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TestURLRequest.test_methodNormalization fails on macOS 27

1 participant