Repository navigation
fix(requests): preserve TV requests on lookup failures - #262
Merged
Merged
Conversation
9 of 11 tasks
|
Hey @snapetech, thanks for submitting this PR! However, it looks like the PR template hasn't been fully filled out. Issues found:
Please update your PR description to follow the PR template. This check will automatically re-run when you edit your PR description. |
8 of 11 tasks
snapetech
force-pushed
the
codex/upstream-tvdb-request-recovery-20261013
branch
from
October 13, 2026 22:12
db5fcf9 to
10a57d6
Compare
snapetech
marked this pull request as ready for review
October 15, 2026 13:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TV requests can fail when TMDB has no TVDB identifier and Sonarr requires one. The old dispatch path removed both the media row and request before the normal failure handler could retain them. This change checks TVDB's TMDB remote-ID records, then the selected Sonarr server's TMDB lookup, and keeps unresolved requests visible as failed.
For IDs resolved outside TMDB, requested regular-season numbers are checked against official TVDB season data before dispatch. Missing or mismatched season data fails safely, while specials remain eligible. Fallback IDs are used for dispatch only and are not written to SeerrNG's uniquely constrained shared TVDB field.
This work is informed by Seerr issue #3488, PR #3489, and PR #3490. The implementation follows SeerrNG's existing TVDB provider, Servarr response sanitization, request lifecycle, and shared-media identity constraints. Alternate season-number mapping remains separate work.
Codex assisted with investigation, implementation, and tests; the maintainer reviewed the resulting changes.
How Has This Been Tested?
pnpm test:node server/api/servarr/sonarr.test.ts server/api/tvdb/videoMetadata.test.ts server/test/MediaRequestSubscriber.test.ts— 67 passed, 0 failed.pnpm typecheck:server— passed.git diff --check— passed.pnpm release-notes:preview --base origin/main --head HEAD— includes the new Requests fix note.Screenshots / Logs (if applicable)
No UI changes.
Release Notes
release-notes/tvdb-request-recovery.md.pnpm release-notes:preview.Checklist:
pnpm build.pnpm i18n:extract.