Repository navigation
docs: describe the cross-origin request protection of 1.28.1 - #17
Merged
Merged
Conversation
Sortie 1.28.1 refuses a state-changing request that a browser sends from a page on another origin. Document which requests are refused, the new 403 error code, the Host header a reverse proxy must pass through, and add the 1.28.1 release to the changelog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Scope & Context
Type: Chore
Intent: Document the security fix shipped in Sortie 1.28.1: the HTTP server refuses a state-changing request that a browser sends from a page on another origin. Operators need to know which requests are refused, what the new
403looks like, and that a reverse proxy must pass the browser'sHostheader through unchanged. The changelog gains the 1.28.1 release.Related Issues: sortie-ai/sortie#1424
🧭 Reviewer Guide
Complexity: Low
Entry Point
content/reference/http-api.md, new section "Cross-origin requests": the one place that holds the full decision order (Sec-Fetch-Sitefirst, thenOriginagainstHost), thecross_origin_request_rejectederror, the pre-routing precedence over404and405, and the proxy requirement. Every other page links there instead of repeating it.Sensitive Areas
content/changelog.md: the 1.28.1 entry follows the shape of earlier patch releases and links the advisory GHSA-hrwv-5v9g-qv57.content/guides/deploy-sortie-to-kubernetes.md: one sentence added to the Ingress advice about passingHostthrough.