Repository navigation
Conversation
Wraps every join point and reachable type of a varied C++ AST with a cold and a warm cache and compares each result with a per-instance mapper lookup. Also checks that each Java class has one join point type, that mappers registered after the cache is warm take effect, that a missing mapper error is not cached, and that other Java values (File, Class, SourceRange) are returned as-is.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
specs-feup/lara-framework#121 makes
wrapJoinPointcache its per-object classification by Java class, which makes it about 300x faster and the Clava-JS suite about 23% faster. It also returns non-join-point Java objects as-is instead of throwing. Clava has the real join point classes, so the cache is tested here.The new
WrapJoinPoint.test.ts:$file.file,getKeyTypeandgetValue("location")return Java objects as-is, where they used to throw.getValuestill converts lists and join points.Assertions compare classes, never join points. When vitest prints a join point in a failure message it runs the getters through node-java, which can abort the test worker.
Needs specs-feup/lara-framework#121 (same branch name, resolved by CI). Stacked on #266.
Changes made by Claude Opus 5.5 (
claude-opus-5-5) via Claude Code.