Skip to content

More Codex Fixes - #4318

Merged
nasbench merged 3 commits into
developfrom
more-fixes-6.8
Oct 6, 2026
Merged

nasbench merged 3 commits into
developfrom
more-fixes-6.8

Conversation

@nasbench

@nasbench nasbench commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Apply a couple more fixes from codex

Comment thread detections/endpoint/windows_renamed_lolbas_binary_was_executed.yml Outdated
Comment thread detections/endpoint/windows_renamed_popular_3rd_party_software_was_executed.yml Outdated
Co-authored-by: Nasreddine Bencherchali <nbencher@cisco.com>
@nasbench nasbench added this to the v6.8.0 milestone Oct 5, 2026
@nasbench

nasbench commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T09:27:33.839707Z 8b2535a Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: 8b2535a768

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@nasbench

nasbench commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

After discussing with @onurmerdogan - We think the FP rate that could be introduced by such change is acceptable to gain visibility into the FN that were hidden. The rule is still low with 20 score by default. So we're good.

@nasbench
nasbench merged commit ce03ed3 into develop Oct 6, 2026
6 checks passed
@nasbench
nasbench deleted the more-fixes-6.8 branch October 6, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants