Repository navigation
Fix reactive deleteById with id publisher and refresh policy. - #3385
Open
chuuminggg wants to merge 1 commit into
Open
chuuminggg wants to merge 1 commit into
chuuminggg wants to merge 1 commit into
Conversation
SimpleReactiveElasticsearchRepository.deleteById(Publisher, RefreshPolicy) passed the publisher instead of the emitted id to deleteById, so it called itself again and failed with a StackOverflowError. Pass the emitted id. Closes spring-projects#3384 Signed-off-by: chuuminggg <rorrxr@naver.com>
spring-projects-issues
added
the
status: waiting-for-triage
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3384
deleteById(Publisher<ID>, RefreshPolicy)now passes the emitted id instead of the publisher, so it deletes the document instead of calling itself.Added an integration test to
SimpleReactiveElasticsearchRepositoryIntegrationTeststhat deletes by an id publisher withRefreshPolicy.IMMEDIATE. The test repository now extendsReactiveElasticsearchRepositoryso the overload can be called.