Repository navigation
Brotli compression - #1
Merged
Merged
Conversation
carlohamalainen
marked this pull request as draft
October 7, 2026 23:36
carlohamalainen
force-pushed
the
carlo/brotli01
branch
from
October 8, 2026 00:06
3e68152 to
bd58b0d
Compare
saviorand
reviewed
Oct 8, 2026
saviorand
left a comment
saviorand
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, a few points inline.
….json and gitignore
…BROTLI_TESTING` guard.
Open
carlohamalainen
force-pushed
the
carlo/brotli01
branch
from
October 9, 2026 02:24
bd58b0d to
8869738
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@saviorand Here's a prototype of Brotli compression.
I decided to vendor in the Brotli C source and wrote a minimalist FFI wrapper just for compression of streams. This gives us complete control over the library version, interface, and parameters. I think the same approach will work for zstd and zlib.
I hand wrote the C FFI and Lean code in the library.
Claude wrote all the tests - I vibed it with "We aspire to Richard Hipp level of testing as he does with SQLite."