Skip to content

docs: add Aaron reviewer skill - #2662

Open
erichare wants to merge 1 commit into
mainfrom
feat/aaron-reviewer-skill
Open

erichare wants to merge 1 commit into
mainfrom
feat/aaron-reviewer-skill

Conversation

@erichare

@erichare erichare commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

What this PR does:

Adds a project-local aaron-reviewer skill and source-linked evidence profile, grounded in all 217 data-api PRs where Aaron Morton reviewed or commented (1,835 nonempty review bodies). The skill emphasizes correctness, stable API contracts, meaningful tests, clear ownership, narrow scope, calibrated severity, and candid review boundaries. Includes the approved design and implementation plan.

Which issue(s) this PR fixes:

Not applicable — reviewer tooling and documentation only; no runtime bug. The validated profile is also stored in Mem0.

Verification:

Thirty-two fresh-agent scenario reviews compared baseline and skilled behavior. Baseline caught stable error titles and partial-last pagination in 0/5 samples each; the skill improved both to 5/5 while preserving shared-state and scope findings. A held-out review of PR #2644 approved without invented blockers and passed its focused MCP test. Final independent review corrections were applied and rechecked.

./mvnw -q test -DskipITs passed with 3,618 tests, 0 failures, 0 errors, 0 skipped. The full ./mvnw -q test task had eight environmental errors (seven Quarkus config-injection errors and one missing-Docker error), so integration coverage remains unverified.

./mvnw -q test -DskipITs
./mvnw -Dtest=McpProtocolTest test

Checklist

  • Changes manually tested
  • Automated Tests added/updated (not applicable; documentation-only)
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@erichare
erichare requested a review from a team as a code owner October 27, 2026 18:19
@github-actions

Copy link
Copy Markdown
Contributor

➡️ Unit Test Coverage Delta vs Main Branch

Metric Value
Main Branch 55.07%
This PR 55.07%
Delta ⚪ 0.00%
ℹ️ Coverage unchanged

@github-actions

Copy link
Copy Markdown
Contributor

Unit Test Coverage Report

Overall Project 55.07% 🍏

There is no coverage information present for the Files changed

@github-actions

Copy link
Copy Markdown
Contributor

➡️ Integration Test Coverage Delta vs Main Branch (hcd-it)

Metric Value
Main Branch 74.35%
This PR 74.35%
Delta ⚪ 0.00%
ℹ️ Coverage unchanged

@github-actions

Copy link
Copy Markdown
Contributor

Integration Test Coverage Report (hcd-it)

Overall Project 74.35% 🍏

There is no coverage information present for the Files changed

@github-actions

Copy link
Copy Markdown
Contributor

➡️ Integration Test Coverage Delta vs Main Branch (dse69-it)

Metric Value
Main Branch 73.04%
This PR 73.04%
Delta ⚪ 0.00%
ℹ️ Coverage unchanged

@github-actions

Copy link
Copy Markdown
Contributor

Integration Test Coverage Report (dse69-it)

Overall Project 73.04% 🍏

There is no coverage information present for the Files changed

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant