Repository navigation
refactor: use constants/float32/nan in math/base/special/minf - #16673
Open
Mustansir-06 wants to merge 1 commit into
Open
Mustansir-06 wants to merge 1 commit into
Mustansir-06 wants to merge 1 commit into
Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11743.
Description
This pull request:
0.0f / 0.0f) inmath/base/special/minf/src/main.cwith the stdlib NaN constantSTDLIB_CONSTANT_FLOAT32_NANfrom@stdlib/constants/float32/nan.#include "stdlib/constants/float32/nan.h"alongside the existing stdlib includes insrc/main.c.@stdlib/constants/float32/nanas a dependency in thebuild,benchmarkandexamplesconfigurations inmanifest.json.No inline NaN generation remained in this package's C example, C benchmark or README, so only
src/main.candmanifest.jsonchanged.Related Issues
This pull request has the following related issues:
Reference Packages
This pull request followed these packages:
stats/strided/dnanmeanpn(refactor: useconstants/float64/nan#11768),stats/strided/snanmeanpn(refactor: useconstants/float32/nan#11769) andmath/base/special/maxf(refactor: useconstants/float32/naninmath/base/special/maxf#16637).src/main.c.maxf(withninfand the negative-zero check in place ofpinfand the positive-zero check), so the same two-file change applied.Questions
No.
Other
I'm on Windows and could not run the project's
makebuild and lint locally. To check that behavior is unchanged, I compiledsrc/main.cwithgcctogether with its dependencies, before and after the change, and confirmed thatstdlib_base_minf( NaN, 1.0f )returns NaN andstdlib_base_minf( 3.0f, 4.0f )returns3.0fin both cases. I'm relying on CI for the rest.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
N/A
@stdlib-js/reviewers