Skip to content

chore: add missing new in REPL examples in blas/ext/base/ndarray/* - #16674

Draft
Planeshifter wants to merge 1 commit into
developfrom
claude/trusting-cannon-kobxev
Draft

Planeshifter wants to merge 1 commit into
developfrom
claude/trusting-cannon-kobxev

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

  • propagates fixes merged to develop between 2026-11-16T02:00Z and 2026-11-17T02:05Z to sibling packages.
  • propagates d5434ac ("chore: clean-up"), which added the missing new keyword when invoking an ndarray constructor alias in blas/ext/base/ndarray/caxpby/docs/repl.txt. The same omission exists for ndarray/vector/float32 and ndarray/vector/float64 in the REPL examples of the following packages, each of which already uses new in its README and JSDoc:
    • blas/ext/base/ndarray/dleft-pad-circular
    • blas/ext/base/ndarray/dleft-pad-edge
    • blas/ext/base/ndarray/sleft-pad-circular
    • blas/ext/base/ndarray/sright-pad-circular

Related Issues

Does this pull request have any related issues?

No.

Reference Packages

Did the content of this pull request follow one or more existing packages? Answering is optional.

This pull request followed these packages:

  • blas/ext/base/ndarray/caxpby

What carried over from the reference(s)?

  • The new {{alias:...}}( ... ) form for constructor aliases in docs/repl.txt.

What differed, or what did you have to work out yourself?

  • None. The fix is mechanical: one line per file.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation: searched all docs/repl.txt files for {{alias:@stdlib/ndarray/(tensor0d|vector|matrix|tensor3d)/<dtype>}}( without a preceding new, excluding the vector/ctor factory (a plain function). The four sites above are the only remaining occurrences; 260+ sibling lines already use new. Two independent validation passes and a style pass confirmed each site. None of the edited files are autogenerated.

Excluded: the other source-window commits are either generated (namespace TOCs, equations, related packages), single-site or non-generalizable (tensor3d test descriptions, deps/test int main( void ) with no remaining sites), or part of the ongoing contributor-driven migration tracked in #16654.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written primarily by Claude Code as part of an automated fix-propagation routine.


@stdlib-js/reviewers


Generated by Claude Code

Propagates fix from d5434ac ("chore: clean-up") to sibling packages whose REPL examples invoke an ndarray vector constructor alias without `new`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017wWD7AgTY94Q1EvzJQsG3u
@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Good First PR A pull request resolving a Good First Issue. labels Nov 17, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/ndarray/dleft-pad-circular $\\color{green}127/127$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}127/127$
$\\color{green}+100.00\\%$
blas/ext/base/ndarray/dleft-pad-edge $\\color{green}127/127$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}127/127$
$\\color{green}+100.00\\%$
blas/ext/base/ndarray/sleft-pad-circular $\\color{green}127/127$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}127/127$
$\\color{green}+100.00\\%$
blas/ext/base/ndarray/sright-pad-circular $\\color{green}127/127$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}127/127$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Good First PR A pull request resolving a Good First Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants