Repository navigation
docs: use dedicated zero-dimensional tensor constructor in blas/ext/base/ndarray/cunitspace - #16675
Open
Deepanshu-Mehta wants to merge 1 commit into
Open
Deepanshu-Mehta wants to merge 1 commit into
Deepanshu-Mehta wants to merge 1 commit into
Conversation
…base/ndarray/cunitspace` Replace `@stdlib/ndarray/from-scalar` with `@stdlib/ndarray/tensor0d/complex64` when creating the zero-dimensional `start` ndarray in the README, REPL text, TypeScript declarations example, JSDoc examples, example script, and benchmark. Runtime behavior and the unit tests are unchanged. Ref: stdlib-js#16654
Contributor
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #16654.
Description
This pull request:
@stdlib/blas/ext/base/ndarray/cunitspaceto use the dedicatedComplex64Tensor0Dconstructor (@stdlib/ndarray/tensor0d/complex64) instead of@stdlib/ndarray/from-scalarwhen creating the zero-dimensionalstartndarray. The change covers the README examples, REPL text, TypeScript declaration example, JSDoc examples (lib/index.js,lib/main.js),examples/index.js, and the benchmark.Runtime code, TypeScript signatures, and unit tests are unchanged. The only edits under
lib/are@examplecomments.Related Issues
This pull request has the following related issues:
Reference Packages
This pull request followed these packages:
blas/ext/base/ndarray/daxpby(commit 3757981, referenced in the issue)blas/ext/base/ndarray/caxpby(for theComplex64Tensor0Dpattern)from-scalarplus the{ 'dtype': ... }options object with the typedtensor0dconstructor.complex64takes the real and imaginary parts directly (new Complex64Tensor0D( 3.0, 0.0 )), so the intermediateComplex64instance and itsrequirewere removed.test/test.jsuses@stdlib/ndarray/base/from-scalarwith explicit dtype and order arguments, not the publicfrom-scalarthis issue targets, so it was left unchanged.Questions
No.
Other
Run locally for this package:
examples/index.jsmax-lenwarning intest/test.js, which this PR doesn't touch)make lint-javascript-fileson the changed JavaScript filesmake lint-markdown-files/remarkon the README (no issues)@stdlib/_tools/lint/repl-txt) on the package'sdocs/repl.txt(no errors or warnings)Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
N/A. No AI assistance was used.
@stdlib-js/reviewers