Skip to content

🗓️ Add 2019 meeting notes - #2782

Open
JFWooten4 wants to merge 18 commits into
stellar:mainfrom
JFWooten4:2019-meetings
Open

JFWooten4 wants to merge 18 commits into
stellar:mainfrom
JFWooten4:2019-meetings

Conversation

@JFWooten4

Copy link
Copy Markdown
Contributor

for #1087

JFWooten4 and others added 2 commits August 23, 2026 17:24
Co-authored-by: Codex Web <noreply@openai.com>
Copilot AI balanced review requested due to automatic review settings August 23, 2026 22:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds ten 2019 meeting archives to the meetings collection, including historical protocol discussions and one Meridian recording.

Changes:

  • Adds 2019 meeting summaries and proposal tags.
  • Registers Johnny Goodnow as an author.
  • Updates generated meeting, author, tag, and pagination routes.

Recommendation: NEEDS-CHANGES — Correct proposal formatting/titles, missing CAP-6 tagging, and inaccurate metadata.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 13 comments.

Show a summary per file
File Description
routes.txt Adds generated meeting and taxonomy routes.
meetings/authors.yml Adds the meeting-note author profile.
meetings/2019-01-24.mdx Archives January protocol discussions.
meetings/2019-03-07.mdx Summarizes protocol priorities and proposals.
meetings/2019-03-14.mdx Documents trustline and fee discussions.
meetings/2019-03-21.mdx Covers authorization, fees, and order books.
meetings/2019-03-28.mdx Records CAP and multisig discussions.
meetings/2019-04-04.mdx Documents mergeable-trustline proposals.
meetings/2019-06-13.mdx Summarizes precondition and fee-bump work.
meetings/2019-06-27.mdx Details payment and precondition proposals.
meetings/2019-07-25.mdx Records several CAP decisions.
meetings/2019-11-04.mdx Embeds and summarizes a Meridian address.
Suppressed comments (7)

meetings/2019-01-24.mdx:22

  • The proposal names in this page are displayed with zero-padding (for example, CAP-0005), contrary to the repository rule in CONTRIBUTING.md:85 requiring CAP-5/SEP-13 in prose while retaining padded canonical filenames in URLs. Please update all displayed CAP/SEP references on this page; the affected text includes lines 22–31, 45–48, 54, 59, and 63–64.
- [CAP-0005](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0005.md) & [CAP-0006](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0006.md) - moving to approval.

meetings/2019-03-07.mdx:75

  • This labels CAP-15 as “Bump Fee Transactions,” but the linked canonical proposal's title is “Fee-Bump Transactions.” Use the canonical title consistently so readers can identify the proposal unambiguously.
  - [CAP-0015](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0015.md) - Bump Fee Transactions (OrbitLens)

meetings/2019-03-28.mdx:25

  • “Bump Fee Extension” is not the linked CAP-15 title; the canonical proposal is “Fee-Bump Transactions.” Use the canonical title consistently so readers can identify the proposal unambiguously.
- [CAP-0015](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0015.md) (Bump Fee Extension): Modified to utilize [CAP-0019](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0019.md). Goal is to bring it to a vote, or enumerate what is needed to make it pass.

meetings/2019-03-14.mdx:34

  • These descriptions are not the canonical proposal titles. The linked specifications call SEP-17 “Issuer account funding protocol (CAP-13 Based)” and SEP-16 “Account Transfer Permissionless Payment Protocol (atp3).” Please use those titles so the historical notes identify the proposals accurately.
  - [SEP-0017](https://github.com/stellar/stellar-protocol/blob/master/ecosystem/sep-0017.md): Deposit & transfer of assets using [CAP-0013](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0013.md)
  - [SEP-0016](https://github.com/stellar/stellar-protocol/blob/master/ecosystem/sep-0016.md): Deposit & transfer of assets using deterministic accounts

meetings/2019-06-27.mdx:22

  • The canonical CAP-23 title is “Two-Part Payments with ClaimableBalanceEntry,” not “Two-Part Payments with BalanceEntry.” Because the body also uses names from an earlier draft, clarify the historical terminology while giving the linked proposal its canonical title.
- [CAP-0023](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0023.md) - _Two-Part Payments with BalanceEntry_

meetings/2019-07-25.mdx:18

  • “Path Payment w/Fixed Amount” is not CAP-24's canonical title. The linked proposal is titled “Make PathPayment Symmetrical”; use that title here.
- [CAP-0024](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0024.md) - Path Payment w/Fixed Amount

meetings/2019-07-25.mdx:24

  • The CAP-25 label is not its canonical title: the linked proposal is “Remove Bucket Shadowing,” not “Shadow Bucket Removal.” Use the canonical proposal titles in this summary.
- [CAP-0021](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0021.md), [CAP-0022](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0022.md), [CAP-0025](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0025.md) - Preconditions, Invalid Transaction Effects, Shadow Bucket Removal

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread meetings/2019-03-07.mdx Outdated
Comment thread meetings/2019-03-14.mdx Outdated
Comment thread meetings/2019-03-21.mdx Outdated
Comment thread meetings/2019-03-28.mdx Outdated
Comment thread meetings/2019-04-04.mdx Outdated
Comment thread meetings/2019-01-24.mdx
Comment thread meetings/2019-01-24.mdx Outdated
Comment thread meetings/2019-11-04.mdx Outdated
Comment thread meetings/2019-06-27.mdx Outdated
Comment thread meetings/2019-11-04.mdx Outdated
JFWooten4 and others added 3 commits August 24, 2026 09:43
Use unpadded proposal identifiers in meeting prose while preserving canonical padded filenames in URLs.

Co-authored-by: Codex <noreply@openai.com>
Add CAP-6 discovery metadata, use the canonical CAP-15 title, and record the generated tag route.

Co-authored-by: Codex <noreply@openai.com>
Pin the CAP-7 draft to its final historical revision and use the canonical SEP-16 title.

Co-authored-by: Codex <noreply@openai.com>
@JFWooten4

Copy link
Copy Markdown
Contributor Author

There are some historic CAP title wordings maintained verbatim from the actual notes archive because they carry the precedence historical framing of the proposals while they were WIPs.

"BalanceEntry_" as an example shows original intent.

JFWooten4 and others added 12 commits August 24, 2026 10:04
Correct the proper-name capitalization in the Meridian meeting summary.

Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
@stellar-triage-bot

Copy link
Copy Markdown
Contributor

🤖 Automated message from the Stellar Triage Bot.

Reviewing because this PR is stale (no update in 4+ weeks).

Should the docs archive 2019 meetings? @kaankacar called retroactive archives out of scope on #1087, then closed it. The same call covers #2783 to #2786. @kaankacar @ElliotFriend

  • The notes match Johnny Goodnow's stellar-dev posts. I fixed the burn total to 55 billion (per SDF's 2019 post).
  • If yes: routes.txt conflicts with main (keep both lines). The Meridian page credits Goodnow, who did not write it.
  • No live preview was available.

@stellar-triage-bot stellar-triage-bot Bot added the bot:needs-decision Bot needs a maintainer decision (listing, scope, policy) label Oct 8, 2026
@kaankacar

kaankacar commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Hi @JFWooten4, thank you for this PR. Our decision: yes, the docs will include the 2019 protocol meeting notes. For every year, the archive includes protocol meetings and standards discussions only.

Please make these changes:

  1. Remove the Meridian page. Delete meetings/2019-11-04.mdx and its route /meetings/2019/11/04. It is a conference talk, not a meeting. It also credits Johnny Goodnow, who did not write it. Keep the goodnow author entry for the nine meeting notes.
  2. Use the tag set from main. Set tags: [protocol, legacy] on the nine remaining pages. Remove the CAP and SEP tags. The CAP and SEP numbers stay in the page text, so search still finds them. In routes.txt, remove the routes of the deleted tags (/meetings/tags/cap-*, /meetings/tags/sep-*, /meetings/tags/community) and keep /meetings/tags/legacy.
  3. Merge main to fix the routes.txt conflict.

Thanks again for your work on this archive.

@kaankacar kaankacar added bot:hands-off Keep the triage bot away from this issue or PR while the label is on and removed bot:needs-decision Bot needs a maintainer decision (listing, scope, policy) labels Oct 15, 2026
@stellar-triage-bot

Copy link
Copy Markdown
Contributor

🤖 Automated message from the Stellar Triage Bot.

Standing down because @kaankacar added bot:hands-off.

  • I pushed nothing to this branch.
  • Note for @JFWooten4: after these changes and a merge of main, the meetings blog has 100 posts (12 per page). So routes.txt also needs /meetings/page/9.
  • The hold issue stellar/github-triage-bot#37 is still open. @kaankacar, close it when you are ready.

To call me back: anyone with write permission can comment /triage or add the bot:take label. The PR author can send me away with /triage stop. People with write permission can also use the bot:hands-off label. A review request to a maintainer does not call me in.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:hands-off Keep the triage bot away from this issue or PR while the label is on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants