Repository navigation
build(deps): refactor CMake files for finding abseil-cpp - #148
Closed
ingomueller-net wants to merge 3 commits into
Closed
ingomueller-net wants to merge 3 commits into
ingomueller-net wants to merge 3 commits into
Conversation
This PR refactors the CMake logic that finds or fetches the GTest/googletest dependency. It follows the same pattern applied by substrait-io#138 for the protobuf library. The PR also removes a redundant logic of finding/fetching that dependency, which previously existed twice. Signed-off-by: Ingo Müller <ingomueller@google.com>
This PR refactors the CMake logic that finds or fetches the abseil-cpp dependency. It follows the same pattern applied by substrait-io#138 for the protobuf library. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
added a commit
to ingomueller-net/substrait-cpp
that referenced
this pull request
Mar 31, 2026
This PR applies more fixes found by `clang-tidy`. Curiously, they only show up with substrait-io#148, which consumes `abseil-cpp` differently. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
force-pushed
the
cmake-revamp-abseil
branch
4 times, most recently
from
March 31, 2026 10:56
45baccf to
145e0db
Compare
ingomueller-net
force-pushed
the
cmake-revamp-abseil
branch
from
March 31, 2026 10:59
145e0db to
054f361
Compare
Contributor
Author
|
Closing because we don't need this anymore anyways: the code is now not compatible with Protobuf before v22, and that version ships with Abseil. See failed job. |
ingomueller-net
added a commit
to ingomueller-net/substrait-cpp
that referenced
this pull request
Apr 7, 2026
This PR applies more fixes found by `clang-tidy`. Curiously, they only show up with substrait-io#148, which consumes `abseil-cpp` differently. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
added a commit
to ingomueller-net/substrait-cpp
that referenced
this pull request
Apr 9, 2026
This PR improves the way how CMake sets up `clang-tidy` in two ways: (1) It includes a `--header-filter` in order to make `clang-tidy` also check and fix header files and (2) it deactivates `clang-tidy` checks for generated code, namely by `protoc` and ANTLR. This PR then applies more fixes found by `clang-tidy`. Curiously, some of them only show up with substrait-io#148, which consumes `abseil-cpp` differently. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
added a commit
to ingomueller-net/substrait-cpp
that referenced
this pull request
Apr 9, 2026
This PR applies more fixes found by `clang-tidy`. Curiously, they only show up with substrait-io#148, which consumes `abseil-cpp` differently. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
added a commit
to ingomueller-net/substrait-cpp
that referenced
this pull request
Apr 9, 2026
This PR improves the way how CMake sets up `clang-tidy` in two ways: (1) It includes a `--header-filter` in order to make `clang-tidy` also check and fix header files and (2) it deactivates `clang-tidy` checks for generated code, namely by `protoc` and ANTLR. This PR then applies more fixes found by `clang-tidy`. Curiously, some of them only show up with substrait-io#148, which consumes `abseil-cpp` differently. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
added a commit
to ingomueller-net/substrait-cpp
that referenced
this pull request
Apr 9, 2026
This PR applies more fixes found by `clang-tidy`. Curiously, they only show up with substrait-io#148, which consumes `abseil-cpp` differently. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
added a commit
to ingomueller-net/substrait-cpp
that referenced
this pull request
Apr 9, 2026
This PR improves the way how CMake sets up `clang-tidy` in two ways: (1) It includes a `--header-filter` in order to make `clang-tidy` also check and fix header files and (2) it deactivates `clang-tidy` checks for generated code, namely by `protoc` and ANTLR. This PR then applies more fixes found by `clang-tidy`. Curiously, some of them only show up with substrait-io#148, which consumes `abseil-cpp` differently. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
added a commit
to ingomueller-net/substrait-cpp
that referenced
this pull request
Apr 9, 2026
This PR applies more fixes found by `clang-tidy`. Curiously, they only show up with substrait-io#148, which consumes `abseil-cpp` differently. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
added a commit
that referenced
this pull request
Apr 9, 2026
This PR improves the way how CMake sets up `clang-tidy` in two ways: (1) It includes a `--header-filter` in order to make `clang-tidy` also check and fix header files and (2) it deactivates `clang-tidy` checks for generated code, namely by `protoc` and ANTLR. This PR then applies more fixes found by `clang-tidy`. Curiously, some of them only show up with #148, which consumes `abseil-cpp` differently. --------- Signed-off-by: Ingo Müller <ingomueller@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is currently stacked on #140.
This PR refactors the CMake logic that finds or fetches the abseil-cpp dependency. It follows the same pattern applied by #138 for the protobuf library.