Skip to content

Unify node imports and add Pali governance voting - #49

Merged
sidhujag merged 2 commits into
masterfrom
codex/unified-node-import
Oct 17, 2026
Merged

sidhujag merged 2 commits into
masterfrom
codex/unified-node-import

Conversation

@sidhujag

@sidhujag sidhujag commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Give Nodes one Import entrypoint for bounded, reviewed public ProTx batches and the existing encrypted browser voting vault. Keep node watching, voting custody and owner/operator authority distinct.
  • Report every invalid, duplicate and excess line; verify the selected network before adding a watch; preserve existing labels atomically; retry only failed rows. Reject private-key-shaped public labels before lookup or saving, including labels from legacy vault discovery.
  • Offer an explicit governance custody choice: existing browser/phone vault or typed Pali voting. Verify returned Core-compatible signatures against the exact selected nodes, collateral, proposal, outcome, time and registered voting identity before relay.
  • Keep uncertain relay outcomes non-retryable until status reconciliation, then retry identical approved signatures. PQ voting remains gated; no wallet-key inventory API or private-key transfer to the webpage.
  • Keep the browser import title visible at 320px and move optional descriptor examples into a disclosure.

Validation

  • 61 suites / 978 unit tests passed (runner exit 0; repository's existing worker-shutdown warning remains).
  • Production build passed; 4 production-runtime checks passed; production dependency audit reports 0 vulnerabilities.
  • All 12 browser scenarios passed across the full existing Sentry set plus batch import, explicit Pali voting, uncertain-result recovery and missing-key error states. 320px viewport captures reviewed.
  • Six literal Core-native compact signature vectors pass, including compressed and uncompressed registered voting identities.
  • Realistic governance fixtures use distinct object Key and nested DataHash values; Pali voting and relay remain bound to Key.
  • Independent frontend review completed; its uncertain-reconciliation retry finding was fixed and regression tested.

Coordinated rollout

Requires sysnode-backend #38 for preserveExisting: true and /api/sentry/v1/voting-context, and a Pali build exposing governanceVote plus sys_signSentryVote. Missing support fails closed. This PR has not been deployed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-17T19:34:16.160954Z 33bad08 Manual request
🔒 Security Review ⚠️ Failed 2026-10-17T19:25:45.012094Z 3d3cba8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sidhujag

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 3d3cba82c2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@sidhujag

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 33bad08328

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@sidhujag
sidhujag merged commit 351a283 into master Oct 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant