Skip to content

[TYPE 3] [Allow to override constants]  #1186

Open

Description

@ludwigrubio

Summary

Create a configuration file to centralize all constant in a single place, allowing users to override values as needed (Monkey patching)

Description

There is a constant FILESIZE_LIMIT in the datasources_endpoint.py file that is hardcoded to chunk files after 64 MB.

Security policies implemented in a firewall on top of an application could have constrains about the max size of body request or max file upload that could differ in case to case and requires file to be chunked in smaller pieces.

Activity

  1. jacalata commented on Mar 27, 2023

    @jacalata
    Contributor

    Sounds very reasonable, shouldn't be too hard.

  2. Salatich commented on Jul 8, 2024

    @Salatich

    Thumbs up, it would be nice to have a possibility to override CHUNK_SIZE_MB as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions