Repository navigation
[Dashboard] Fix: reject unsafe checkout redirects and isolate opener - #9075
Open
yinbowen-dc wants to merge 1 commit into
Open
yinbowen-dc wants to merge 1 commit into
yinbowen-dc wants to merge 1 commit into
Conversation
|
|
@yinbowen-dc is attempting to deploy a commit to the thirdweb Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Payment-link success redirects now reject malformed/non-HTTP URLs and open allowed destinations without an opener reference.
Refs #9061 (the unsafe-scheme and reverse-tabnabbing portions).
PayPageWidgetsuccess callback, consistent with the pay landing page's supported schemes._blankwithnoopener,noreferrerfor allowed destinations.open, analytics, and application context hooks are isolated. No payment is executed.Validation (Node 22.23.4):
turbo run test --filter=thirdweb-dashboard: 6 tasks successful, including SDK build and 16 tests.tsc --noEmit, scoped ESLint/Biome, andgit diff --check: passed./account/settingsand/bridgewith server-component digest1169307521in this local configuration. A complete production build and end-to-end checkout are not claimed.Scope: HTTP(S) redirect destinations remain caller-provided, preserving the existing feature. This patch does not implement merchant-owned allowlists or claim that arbitrary HTTP(S) phishing destinations are prevented; that policy/backend change remains open in #9061. Consequently this uses
Refs, not an automatic issue-closing directive.AI assistance: Codex implemented and tested the patch. Maintainer review is still needed; no human review is claimed.
Summary by CodeRabbit