Repository navigation
Conversation
- Add -f <frame> to inspect a specific frame without playback.
There was a problem hiding this comment.
🟡 Changes recommended
Invalid or negative frame arguments are silently accepted as playback requests, and the new frame-selection option is also missing from the README command-line documentation.
2 open issues
What changed in this PR
Adds a -f <frame> command-line option to the Animation example, allowing users to render a specific animation frame without playback.
Changes:
- Parses and validates the requested frame.
- Applies the selected frame during setup.
- Disables playback updates in fixed-frame mode.
This pull request requires changes.
| File | Summary |
|---|---|
src/Animation.cpp |
Adds frame-option parsing, frame validation, fixed-frame rendering, and playback suppression. Invalid non-numeric, negative, or non-finite values should be rejected explicitly. The new option should also be documented in README.md. |
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Usecase