Skip to content

Animation: add frame selection option - #78

Open
Nor-s wants to merge 1 commit into
mainfrom
nor-s/animation-frame
Open

Nor-s wants to merge 1 commit into
mainfrom
nor-s/animation-frame

Conversation

@Nor-s

@Nor-s Nor-s commented Nov 6, 2026 •

Copy link
Copy Markdown
Member
  • Add -f to inspect a specific frame without playback.

Usecase

./Animation -i coin.json -f 30
image

- Add -f <frame> to inspect a specific frame without playback.
@Nor-s
Nor-s requested review from hermet and tinyjin as code owners November 6, 2026 04:58
Copilot AI lite review requested due to automatic review settings November 6, 2026 04:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Invalid or negative frame arguments are silently accepted as playback requests, and the new frame-selection option is also missing from the README command-line documentation.

2 open issues
What changed in this PR

Adds a -f <frame> command-line option to the Animation example, allowing users to render a specific animation frame without playback.

Changes:

  • Parses and validates the requested frame.
  • Applies the selected frame during setup.
  • Disables playback updates in fixed-frame mode.

This pull request requires changes.

File Summary
src/​Animation.cpp Adds frame-option parsing, frame validation, fixed-frame rendering, and playback suppression. Invalid non-numeric, negative, or non-finite values should be rejected explicitly. The new option should also be documented in README.md.

Review effort: Lite

Comment thread src/Animation.cpp Resolved
Comment thread src/Animation.cpp Resolved
@Nor-s Nor-s self-assigned this Nov 6, 2026
@hermet
hermet removed the request for review from tinyjin November 13, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants