Repository navigation
perf: use a bool vector for intset presence - #77
Merged
Merged
Conversation
The `IntSet`, cut down as it was from re2's SparseArray, had an unnecessary complication in the dense array being an intermediate map of value to index, in regex-filtered that is *only* used to know if the value is already in the set, so a bool does the job more than well enough, for 1/8th the allocation size and a simpler access pattern. This increases throughput by about 5% on a test dataset. Using a BitVec was also tested but it does not increase the throughput quite as much, and requires an otherwise unnecessary dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
IntSet, cut down as it was from re2's SparseArray, had an unnecessary complication in the dense array being an intermediate map of value to index, in regex-filtered that is only used to know if the value is already in the set, so a bool does the job more than well enough, for 1/8th the allocation size and a simpler access pattern.This increases throughput by about 5% on a test dataset.
Using a BitVec was also tested but it does not increase the throughput quite as much, and requires an otherwise unnecessary dependency.