Repository navigation
Conversation
Typed execute params are crop, bg_color, and channels so clients send the current REST body instead of the old remove.bg fields. Co-authored-by: Cursor <cursoragent@cursor.com>
|
alxnik-uc
reviewed
Oct 29, 2026
|
|
||
| - **Breaking**: `AddonRemoveBGExecutionParams` now matches the PhotoRoom API | ||
| (`crop`, `bg_color`, and `channels`). The old remove.bg fields are no longer | ||
| accepted. |
Contributor
There was a problem hiding this comment.
The same question regarding provider we had discussed today. Let's remove provider's references?
Another point:
I suggest to rewrite this to something like:
(`crop_margin`, `scale`, `add_shadow`, `type_level`, `type`, `semitransparency`, `roi`, `position`) are removed with no replacement.
``` - print list of parameters and mention about no other replacement of them
alxnik-uc
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typed execute params are crop, bg_color, and channels so clients send the current REST body instead of the old remove.bg fields.
Description
Checklist