ptx: single-line error for invalid -S regexp by pizzaburgare · Pull Request #14904 · uutils/coreutils

pizzaburgare · 2026-09-28T11:37:09Z

An invalid -S regexp made ptx print the regex crate's multi-line parse error.
GNU prints a single line.

$ ptx -S '['
ptx: Invalid regular expression (for regexp '[')

which matches GNU (aside from locale quoting). The -S test now checks the stderr line.

Ref: #14705 (ptx/ptx.pl).

Closes #14905

Copilot

Copilot review overview

🟡 Changes recommended

Preserve the original -S pattern in diagnostics to avoid misreporting trailing backslashes.

Review effort: Lite
Findings: 1

Open (1)

Preserve original pattern in invalid regex diagnostics · New

What changed in this PR

Updates ptx -S invalid-regexp diagnostics to produce a concise, GNU-compatible single-line error.

Changes:

Simplifies invalid-regexp error formatting.
Updates English and French translations.
Adds an exact stderr regression test.

File	Description
`tests/by-util/test_ptx.rs`	Verifies exact stderr output.
`src/uu/ptx/src/ptx.rs`	Formats invalid-regexp diagnostics.
`src/uu/ptx/locales/fr-FR.ftl`	Updates French messaging.
`src/uu/ptx/locales/en-US.ftl`	Updates English messaging.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Devel08 · 2026-09-28T12:34:36Z

duplicate of #14740
just in case this gets merged, so that I can close my PR

Copilot

Copilot review overview

🔵 Needs a closer look

Preserve the raw regexp in diagnostics and add a regression test for trailing backslashes.

Review effort: Lite
Findings: 1

Open (1)

Preserve original pattern in invalid regex diagnostics

codspeed · 2026-09-28T15:39:26Z

Merging this PR will not alter performance

✅ 10 untouched benchmarks
⏩ 462 skipped benchmarks¹

_{Comparing pizzaburgare:ptx-invalid-sentence-regexp (2e3ffbf) with main (6c880ea)²}

462 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (ae1fd53) during the generation of this report, so 6c880ea was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

sylvestre · 2026-10-08T20:46:00Z

            USimpleError::new(
                1,
-                translate!("ptx-error-invalid-regexp", "error" => error.to_string()),
+                translate!("ptx-error-invalid-regexp", "pattern" => regex.quote()),


what about -W? an invalid word regexp is still silently ignored (empty output), could be a follow-up

Should make test ptx/ptx.pl pass Co-authored-by: pizzaburgare <72048430+pizzaburgare@users.noreply.github.com>

sylvestre · 2026-11-04T07:27:19Z

hi, any news on the comment above? thanks

Copilot

🟢 Approval recommended

No active review issues are reported, and the change includes focused implementation updates with localized diagnostics and parameterized tests covering invalid patterns and command output.

No open issues 🎉

1 resolved since last review

Preserve original pattern in invalid regex diagnostics

_{Review effort: Lite}

pizzaburgare · 2026-11-04T08:30:42Z

Sorry for the slow reply, thanks for fixing it!

github-actions · 2026-11-04T08:55:23Z

GNU testsuite comparison:

Congrats! The gnu test tests/ptx/ptx is no longer failing!

Copilot

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

3 open issues

ptx-error-invalid-regexp previously took $error, and now only $pattern is passed. Only… · New
The PR description/title focuses on -S output formatting, but this test (and the corresponding… · New
Asserting the full, localized stderr string (including quote style) can be brittle if the test… · New

_{Review effort: Lite}

+    Regex::new(&escape_trailing_backslash(pattern)).map_err(|_| {
+        USimpleError::new(
+            1,
+            translate!("ptx-error-invalid-regexp", "pattern" => pattern.quote()),


+#[rstest]
+#[case::sentence("-S", "ab[c")]
+#[case::word("-W", "(wrong")]
+fn test_invalid_regexp(#[case] option: &str, #[case] pattern: &str) {


+        .stderr_is(format!(
+            "ptx: Invalid regular expression (for regexp '{pattern}')\n"
+        ));


Copilot

🟢 Approval recommended

No active review issues are identified, and the changes include focused validation logic with exact diagnostic coverage for invalid patterns.

3 open issues

Asserting the full, localized stderr string (including quote style) can be brittle if the test…
The PR description/title focuses on -S output formatting, but this test (and the corresponding…
ptx-error-invalid-regexp previously took $error, and now only $pattern is passed. Only…

_{Review effort: Lite}

Copilot AI lite review requested due to automatic review settings September 28, 2026 11:37

Copilot started reviewing on behalf of pizzaburgare September 28, 2026 11:40

View session

Copilot AI reviewed Sep 28, 2026

View reviewed changes

Comment thread src/uu/ptx/src/ptx.rs Resolved

xtqqczze requested a review from sylvestre September 28, 2026 12:47

xtqqczze mentioned this pull request Sep 28, 2026

ptx: invalid -S regex must not print a multi-line regex crate error #14740

Closed

This comment was marked as resolved.

Sign in to view

xtqqczze approved these changes Sep 28, 2026

View reviewed changes

Comment thread src/uu/ptx/src/ptx.rs Resolved

Copilot AI review requested due to automatic review settings September 28, 2026 13:25

Copilot started reviewing on behalf of pizzaburgare September 28, 2026 13:32

View session

Copilot AI reviewed Sep 28, 2026

View reviewed changes

This comment was marked as resolved.

Sign in to view

xtqqczze removed the request for review from sylvestre September 28, 2026 13:49

pizzaburgare force-pushed the ptx-invalid-sentence-regexp branch from 703c85e to 5c2fde1 Compare September 28, 2026 14:46

xtqqczze requested a review from sylvestre September 28, 2026 14:50

xtqqczze self-assigned this Sep 28, 2026

sylvestre reviewed Oct 8, 2026

View reviewed changes

ptx: report an invalid -S or -W regex like GNU

2e3ffbf

Should make test ptx/ptx.pl pass Co-authored-by: pizzaburgare <72048430+pizzaburgare@users.noreply.github.com>

sylvestre mentioned this pull request Nov 3, 2026

GNU coreutils 9.12: remaining test failures - Nov 2026 #14705

Open

32 of 76 tasks

sylvestre force-pushed the ptx-invalid-sentence-regexp branch from 5c2fde1 to c945520 Compare November 4, 2026 07:31

Copilot AI lite review requested due to automatic review settings November 4, 2026 07:31

sylvestre force-pushed the ptx-invalid-sentence-regexp branch from c945520 to 594cbc4 Compare November 4, 2026 07:32

Copilot started reviewing on behalf of pizzaburgare November 4, 2026 07:37

View session

Copilot AI reviewed Nov 4, 2026

View reviewed changes

Copilot AI lite review requested due to automatic review settings November 4, 2026 08:41

sylvestre force-pushed the ptx-invalid-sentence-regexp branch from e05e313 to 2e3ffbf Compare November 4, 2026 08:51

Copilot started reviewing on behalf of pizzaburgare November 4, 2026 08:58

View session

Copilot AI reviewed Nov 4, 2026

View reviewed changes

Copilot AI lite review requested due to automatic review settings November 4, 2026 08:58

Copilot started reviewing on behalf of pizzaburgare November 4, 2026 09:13

View session

Copilot AI reviewed Nov 4, 2026

View reviewed changes

sylvestre merged commit 8333be7 into uutils:main Nov 5, 2026
100 checks passed

Conversation

pizzaburgare commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Devel08 commented Sep 28, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

This comment was marked as resolved.

codspeed Bot commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

sylvestre Oct 8, 2026

Choose a reason for hiding this comment

Uh oh!

sylvestre commented Nov 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

pizzaburgare commented Nov 4, 2026

Uh oh!

github-actions Bot commented Nov 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pizzaburgare commented Sep 28, 2026 •

edited

Loading

codspeed Bot commented Sep 28, 2026 •

edited

Loading