Repository navigation
dd: keep numeric-looking values verbatim in errors - #16182
Merged
Merged
Conversation
The argument errors passed the user's value to translate!, which hands anything that parses as a number to Fluent as a number, so `dd 007` printed "unrecognized operand '7'" and `bs=1e3` "invalid number: '1000'". Use translate_text! for these messages so the value is printed as given, like GNU dd.
eylulseyit
force-pushed
the
dd-numeric-operand-verbatim
branch
from
November 4, 2026 22:00
98ced64 to
4c8fc80
Compare
Contributor
|
Thanks for your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The argument errors passed the user's value to translate!, which hands anything that parses as a number to Fluent as a number
Switch the 10 ParseError messages in src/uu/dd/src/parseargs.rs that show the user’s value (operand, flag, conv, status, number) from
translate!totranslate_text!, which always passes the value as a string so Fluent leaves it untouched, the same change already made in tac and tail.Part of #15533