Repository navigation
sed: keep only the low byte of a \d or \o escape above 255 - #641
Open
qodelicious wants to merge 1 commit into
Open
qodelicious wants to merge 1 commit into
qodelicious wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #641 +/- ##
=======================================
Coverage 95.07% 95.08%
=======================================
Files 14 14
Lines 7436 7451 +15
Branches 439 440 +1
=======================================
+ Hits 7070 7085 +15
Misses 365 365
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GNU sed keeps only the low byte of a
\dor\ovalue, so\d513and\o401are both 0x01 and\d321isA. We turned the whole number into a char, so they came out as U+0201 and U+0101 (two bytes each in a UTF-8 locale).This is one of the cases in the GNU testsuite's convert-number.sh.
parse_numeric_escapenow masks the value to 8 bits for the byte escapes (\d,\o,\x).\uand\Uare untouched. Since the regex, replacement andystrings all go throughparse_char_escape, they all get it.Added
test_numeric_escape_keeps_the_low_byteand two unit tests in delimited_parser.rs. They fail on main and pass with the change, and the output matches GNU sed 4.9.cargo test,cargo fmt --checkandcargo clippy --all-targets --all-features -- -D warningspass.