Repository navigation
ci: serve the docs app's static resources in previews (#6669) (CP: v25.3) - #6670
Merged
Merged
Conversation
## What `Dockerfile.preview` now copies `src/main/resources/META-INF/resources` into the static site that the preview serves. The site is copied after them, so the site's own files win if a path clashes. ## Why In production and in the dev server, these resources come from the Spring Boot docs app: requests under `/vaadin/` go to it. Preview deployments serve only the static DSP output with `serve` and don't run that app, so every `/vaadin/*` path returns 404. For example, on the preview of #6668: | Path | Preview | vaadin.com | |---|---|---| | `/vaadin/tutorial/schema.sql` | 404 | 200 | | `/vaadin/videos/aura-theme-editor-teaser.webm` | 404 | 200 | That breaks the SQL downloads in the tutorial's setup step and the video on the Aura theme page in every preview. The preview is served from the site root, so the copied files land at the same paths the articles link to. ## Testing - A minimal Docker build that runs only these two `COPY` lines put the files at `vaadin/tutorial/*.sql`, `vaadin/videos/*.webm` and `icons/*`, and a clashing file from the site overrode the resource. - The full preview build wasn't run locally, as it needs the Pro key. This PR's own preview deployment is the end-to-end check: `/vaadin/tutorial/schema.sql` on it should return 200. Labeled `target/v25.3` because the release branch has the same `Dockerfile.preview`, so previews of PRs to `v25.3` have the same 404s. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.