Repository navigation
docs: document setting node.folder from a Gradle build - #6681
Open
vaadin-bot wants to merge 1 commit into
Open
vaadin-bot wants to merge 1 commit into
vaadin-bot wants to merge 1 commit into
Conversation
Add Gradle command-line and build-script examples for the node.folder property, alongside the existing Maven ones, on the Custom Node.js Folder page. Documents vaadin/flow#26978 (`3f3d09250e27ac7998a4b7cded8aa9a879ed656a`).
caalador
approved these changes
Nov 16, 2026
Contributor
Preview DeploymentThis PR has been deployed for preview. URL: https://docs-preview-pr-6681.fly.dev Changed pagesAdded content is highlighted in green; removed content is marked in red on each page.
Built from af7e349 |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the documentation update adding Gradle options for configuring a custom Node.js folder.
No open issues 🎉
What changed in this PR
Extends Vaadin’s Node.js configuration documentation with Gradle equivalents for setting a custom Node.js folder, alongside the existing Maven examples.
Changes:
- Documents the
-Dvaadin.node.folderand-Pvaadin.node.foldercommand-line options. - Adds a
nodeFolderconfiguration example in thevaadin {}block.
| File | Description |
|---|---|
articles/flow/configuration/development-mode/node-js.adoc |
Adds Gradle instructions for configuring a custom Node.js folder. |
Review effort: Balanced
vaadin-review-bot
left a comment
There was a problem hiding this comment.
✅ Nothing to flag — the changes look good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation for vaadin/flow#26978 by
@totally-not-ai[bot].Note
The source pull request is merged, so this documentation describes the final
shape of the change. Please review it and mark it ready for review.
Change categories: BEHAVIOR_CHANGE (Gradle plugin now reads the
vaadin.node.foldersystem/project property), INTERNAL_ONLY (log message wording and level for the unsupported-global-Node.js case)articles/flow/configuration/development-mode/node-js.adocnode.folderfrom Maven (system property and plugin configuration). Added the Gradle equivalents: setting it on the command line as-Dvaadin.node.folder=...or-Pvaadin.node.folder=..., or in thevaadin {}block.The log-message change in
NodeResolver(naming thevaadin.node.folderproperty and logging at warn vs. info depending on whether the fallback Node.js is already installed) is a diagnostic improvement a reader learns from the console, and the behavior it describes was already documented on this page, so it isn't repeated here.