Repository navigation
feat: add HasAriaDescription to field components - #9811
Merged
Merged
Conversation
vursen
force-pushed
the
feat/has-aria-description
branch
2 times, most recently
from
August 5, 2026 13:49
bb7b0a7 to
2498144
Compare
Maps setAriaDescribedBy / getAriaDescribedBy to the accessibleDescriptionRef web component property, which propagates the reference to the input element. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
vursen
force-pushed
the
feat/has-aria-description
branch
from
August 5, 2026 13:55
2498144 to
2e8d809
Compare
vursen
marked this pull request as ready for review
August 5, 2026 13:57
vursen
marked this pull request as draft
August 5, 2026 13:58
vaadin-review-bot
left a comment
vaadin-review-bot
left a comment
Collaborator
There was a problem hiding this comment.
✅ Nothing to flag — the changes look good.
|
vursen
marked this pull request as ready for review
August 6, 2026 07:57
vaadin-review-bot
left a comment
vaadin-review-bot
left a comment
Collaborator
There was a problem hiding this comment.
✅ Nothing to flag — the changes look good.
DiegoCardoso
approved these changes
Aug 6, 2026
web-padawan
approved these changes
Aug 6, 2026
Collaborator
|
This ticket/PR has been released with Vaadin 25.3.0-alpha8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
HasAriaDescriptionmixin interface to all field components that implementHasAriaLabel, overridingsetAriaDescribedBy/getAriaDescribedByto map to theaccessibleDescriptionRefproperty, which propagates the reference to the input element (the default implementation sets attributes on the host element instead). This follows the same pattern asaccessibleName/accessibleNameRef.DateTimePicker is left out because it doesn't implement
HasAriaLabel,HasPrefixorHasSuffix.Part of vaadin/web-components#11975