Repository navigation
RSDK-14449 - syscfg: report ext4 filesystem errors - #300
Merged
Cheuk (cheukt) merged 3 commits intoOct 6, 2026
Merged
Cheuk (cheukt) merged 3 commits into
Cheuk (cheukt) merged 3 commits into
Conversation
Cheuk (cheukt)
added
the
dev-release
Dev release artifactsBuilt from
Remove the |
Cheuk (cheukt)
added this pull request to stack #301
September 30, 2026 21:29
Member
Author
|
this might be a bit noisy so once it's merged I'll update a few viam-dev robots to the latest build and monitor before releasing |
Josh Matthews (jmatth)
approved these changes
Oct 2, 2026
| func checkExt4Errors(logger logging.Logger, reported map[string]int) { | ||
| all, err := readExt4Errors(ext4SysfsDir) | ||
| if err != nil { | ||
| logger.Debugw("reading ext4 error counters", "error", err) |
There was a problem hiding this comment.
Why only debug level here?
| "go.viam.com/test" | ||
| ) | ||
|
|
||
| func writeExt4Fs(t *testing.T, dir, dev, count, first, last string) { |
There was a problem hiding this comment.
Part of me is tempted to mount a loop device and inject errors so this test can run against real /sys/fs files but it's probably not worth it.
|
Hey Cheuk (@cheukt) — this PR has been approved and CI has been green for 4+ business days. Ready to merge? Auto-comment from overwatch. Will not re-nudge for 7 days. |
Cheuk (cheukt)
force-pushed
the
RSDK-14449-storage-health
branch
from
October 5, 2026 20:21
b77d00c to
3efb379
Compare
Poll /sys/fs/ext4/*/errors_count every 15 minutes and log an error when a filesystem's count rises. SD cards expose no health data, so recorded filesystem corruption is the best early signal of card failure. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Cheuk (cheukt)
force-pushed
the
RSDK-14449-storage-health
branch
from
October 5, 2026 20:28
3efb379 to
c160f53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #299. Every 15 minutes, read
/sys/fs/ext4/*/errors_countand log an error underviam-agent.storagewhen a filesystem's count rises. SD cards have no SMART data, and sysfs still works when journald is stuck.Of the ticket's other items, journald watchdog failures are covered by #299, and
fsck -nis skipped: it gives false positives on a mounted filesystem and adds I/O to a card that's already failing.Tested on a Pi with a loopback ext4 image and
trigger_fs_error.🤖 Generated with Claude Code