Repository navigation
API for interrupting jobs - #357
Merged
Merged
Conversation
rayman2000
reviewed
Aug 17, 2026
Contributor
|
Looks like the test is failing deterministically, can you take a look? |
ArquintL
force-pushed
the
stoppable-verification-server
branch
from
August 20, 2026 05:37
e17cf70 to
0a27088
Compare
Member
Author
|
I've addressed the failing CI, polished the comments, and also unified the lifetime of AST & verification jobs. @rayman2000 could you please take another look? |
ArquintL
force-pushed
the
stoppable-verification-server
branch
from
October 8, 2026 09:31
0a27088 to
23a7367
Compare
This was referenced Oct 8, 2026
Member
Author
|
@rayman2000 In my own words, this PR adds |
Adds `interruptVerification` and `interruptAstConstruction` to `VerificationServer` such that embedders of a plain `ViperCoreServer` (e.g. Gobra) can interrupt a single job without stopping the entire server. So far, only the LSP frontend's `ViperServerService.stopVerification` offered this. The JobActor now replies to `StopProcessRequest`s with a typed `StopProcessReply`, which tells askers whether a task has actually been interrupted. Tests now run with 128MB thread stacks, as `run` does already: the new test's long-running program otherwise overflows the 1MB default stack of Silicon's worker threads on Linux. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
rayman2000
force-pushed
the
stoppable-verification-server
branch
from
October 30, 2026 11:14
23a7367 to
e64f57e
Compare
rayman2000
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
interruptVerificationandinterruptAstConstructiontoVerificationServer. Clients of a plainViperCoreServercan thus interrupt a single job without stopping the whole server. So far, only the LSP frontend could do this, viaViperServerService.stopVerification.Gobra needs this API so that stopping a verification in Gobra-IDE also stops the backend. Without it, the ViperServer job and its prover processes keep running to completion and keep occupying one of the server's job slots.
StopProcessReply(interrupted, message)instead of a string.-Xss128m, asrundoes already. Otherwise, the new test's program overflows the stack of Silicon's worker threads on Linux.This PR used to contain several bug fixes as well. They are now in separate PRs stacked on this one, to be merged in this order:
🤖 Generated with Claude Code