Skip to content

Maint/ci - #27

Merged
viseshrp merged 4 commits into
mainfrom
maint/ci
Mar 9, 2026
Merged

viseshrp merged 4 commits into
mainfrom
maint/ci

Conversation

@viseshrp

@viseshrp viseshrp commented Mar 9, 2026

Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the project's maintenance, CI/CD pipeline, and overall code quality. It includes comprehensive updates to various configuration files, streamlines development scripts, and significantly improves the testing infrastructure. These changes aim to make the development workflow more robust, ensure higher code coverage, and prepare the project for more automated release processes.

Highlights

  • Configuration Updates: Updated .gitignore to include more development-related files and directories, refined biome.json with a newer schema, VCS integration, and specific file inclusions, and updated tsconfig.json to include more configuration files in the build process.
  • Dependency and Script Enhancements: Modified package.json to declare the project as private and use ES modules, added a new lint:webext script for web extension linting, updated the format script to write changes, and upgraded @types/chrome and web-ext dependencies.
  • Testing Infrastructure Improvements: Enhanced vitest.config.ts by enabling globals and increasing code coverage thresholds. Test files (tests/content.spec.ts, tests/options.spec.ts, tests/utils.spec.ts, tests/settings.spec.ts, tests/setup.ts) received minor formatting adjustments, import refinements, and new test cases for utility functions like withTimeout and getErrorMessage.
  • Build Process Refinements: Refactored wxt.config.ts to use environment variables for manifest versioning, configured entrypointsDir and outDirTemplate, and disabled sourcemaps in the Vite build configuration for production builds.
Changelog
  • .gitignore
    • Expanded ignored files to include logs, various debug files, build outputs, and editor-specific directories like .vscode and .idea.
  • biome.json
    • Updated the Biome schema version to 2.4.6.
    • Added VCS configuration to enable Git integration and use the ignore file.
    • Refined file inclusion patterns to target specific code and configuration file types.
    • Disabled the assist feature.
  • package.json
    • Set the package as private and type to module.
    • Added a new lint:webext script for web extension linting.
    • Modified the format script to apply formatting changes directly (--write).
    • Updated @types/chrome and web-ext dev dependencies to newer versions.
  • playwright.config.ts
    • Removed trailing commas in configuration objects for consistent formatting.
  • scripts/smoke.mjs
    • Reordered import statements for execFileSync, existsSync, and resolve.
    • Removed a trailing comma from the requiredFiles array.
  • tests/content.spec.ts
    • Added a blank line after imports.
    • Removed comments related to mocking CSS highlights and Worker.
    • Ensured vi.useRealTimers() is called in afterEach.
    • Reformated the debounce test for improved readability.
  • tests/e2e/fixtures.ts
    • Imported chromium directly from @playwright/test.
    • Used the directly imported chromium for launchPersistentContext.
  • tests/e2e/wxt.e2e.config.ts
    • Removed a trailing comma from the configuration object.
  • tests/options.spec.ts
    • Changed the import of buildSiteRegex from a namespace import (* as utils) to a named import.
    • Updated the usage of buildSiteRegex accordingly.
  • tests/settings.spec.ts
    • Removed trailing commas and adjusted blank lines for consistent formatting.
  • tests/setup.ts
    • Added a global mock for jest to point to vi.
    • Adjusted formatting within the MutationObserver mock class.
  • tests/utils.spec.ts
    • Removed trailing commas and adjusted blank lines for consistent formatting.
    • Updated buildPatternsForTab tests to use toEqual for object comparison and added a test for hosts without a section path.
    • Added new tests for withTimeout to verify promise resolution and rejection behavior.
    • Introduced tests for getErrorMessage to ensure proper error message normalization.
  • tsconfig.json
    • Expanded the include array to cover vitest.config.ts and playwright.config.ts.
  • vitest.config.ts
    • Enabled globals for Vitest.
    • Increased code coverage thresholds for statements, branches, functions, and lines to 90%.
    • Refined coverage include to entrypoints/shared/**/*.ts and added exclude: ['**/*.d.ts'].
  • wxt.config.ts
    • Refactored manifest versioning to use process.env.RELEASE_VERSION or npm_package_version.
    • Added entrypointsDir and outDirTemplate configurations.
    • Configured Vite build to disable sourcemaps.
    • Added homepage_url to the manifest.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/ci.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a number of maintenance and CI improvements across the project. Key changes include updating .gitignore to be more comprehensive, enhancing the Biome configuration to respect gitignore and be more explicit about file inclusion, and updating various npm scripts for formatting and linting. Dependencies like @types/chrome have been updated, and web-ext has been added for web extension linting. The Vitest configuration is improved with stricter coverage thresholds and better include/exclude patterns. The WXT configuration is also updated to be more dynamic. Test files have been refactored for clarity and correctness, with better mocking and new test cases for utility functions. Overall, these are great changes for project health and maintainability. I have one suggestion to make the version handling in wxt.config.ts more robust.

Comment thread wxt.config.ts
@codecov

codecov Bot commented Mar 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.5%. Comparing base (23520f4) to head (fcd7a25).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main     #27     +/-   ##
=======================================
- Coverage   99.5%   98.5%   -1.1%     
=======================================
  Files          2       3      +1     
  Lines        244     349    +105     
  Branches      57      87     +30     
=======================================
+ Hits         243     344    +101     
- Misses         0       5      +5     
+ Partials       1       0      -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@viseshrp
viseshrp merged commit 825b274 into main Mar 9, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant