Skip to content

Fix nullability of bool take - #10411

Merged
robert3005 merged 1 commit into
developfrom
rk/fixers
Oct 9, 2026
Merged

robert3005 merged 1 commit into
developfrom
rk/fixers

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 added the changelog/fix A bug fix label Oct 9, 2026
@robert3005
robert3005 requested a review from myrrc October 9, 2026 11:25
@robert3005
robert3005 enabled auto-merge (squash) October 9, 2026 11:25
@codspeed

codspeed Bot commented Oct 9, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 11.14%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ 1 benchmark measured no execution time

Nothing ran under measurement, usually because the compiler removed the code under test. This result is not comparable, so it counts as unchanged.

Preventing compiler optimizations

❌ 1 regressed benchmark
✅ 2174 untouched benchmarks
⏩ 534 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation random_i128[0.01] 7.1 µs 8 µs -11.14%
⚠️ Simulation bench_compare_primitive[(10000, 2)] < 1 ns < 1 ns N/A

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/fixers (2fe7e37) with develop (c59e52d)

Open in CodSpeed

Footnotes

  1. 534 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@robert3005
robert3005 merged commit 2825d88 into develop Oct 9, 2026
114 of 116 checks passed
@robert3005
robert3005 deleted the rk/fixers branch October 9, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants