Repository navigation
feat(generated): AdminPortal, Agents, ApiKeys, AuditLogs, Authorization, ClientApi, Connect, DirectorySync, Events, FeatureFlags, Groups, MultiFactorAuth, OrganizationDomains, OrganizationMembership, Organizations, Pipes, PipesProvider, PlatformTeams, Radar, SSO, UserManagement, Vault, Webhooks, Widgets (batch aeefef11) - #637
Merged
Merged
Conversation
…iKeys, AuditLogs, Authorization, ClientApi, Connect, DirectorySync, Events, FeatureFlags, Groups, MultiFactorAuth, OrganizationDomains, OrganizationMembership, Organizations, Pipes, PipesProvider, PlatformTeams, Radar, SSO, UserManagement, Vault, Webhooks, Widgets
Contributor
 [Medium impact] Adds agent registration revocation and flag owner tracking. The PR appears safe to merge, with a non-blocking gap in the revoke test. Findings
Fix with agent prompt### Issue 1
agents_test.go:271
The new revoke test returns `"revoked_at": null` and only checks existing fields. It would still pass if `RevokedAt` were removed or its JSON tag were wrong. Return a non-null timestamp here and assert its exact value. Keep the null case in the `GetRegistration` test.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.SummaryAdds agent registration revocation and more response fields.
Reviews (1) · Last reviewed commit: "chore(generated): add release notes frag..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| require.Equal(t, "/agents/registrations/test_id/revoke", r.URL.Path) | ||
| w.Header().Set("Content-Type", "application/json") | ||
| w.WriteHeader(http.StatusOK) | ||
| fixture, err := os.ReadFile("testdata/agent_registration.json") |
Contributor
There was a problem hiding this comment.
The new revoke test returns "revoked_at": null and only checks existing fields. It would still pass if RevokedAt were removed or its JSON tag were wrong. Return a non-null timestamp here and assert its exact value. Keep the null case in the GetRegistration test.
Prompt To Fix With AI
This is a comment left during a code review.
Path: agents_test.go
Line: 271
Comment:
**Revocation timestamp goes untested**
The new revoke test returns `"revoked_at": null` and only checks existing fields. It would still pass if `RevokedAt` were removed or its JSON tag were wrong. Return a non-null timestamp here and assert its exact value. Keep the null case in the `GetRegistration` test.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerated SDK from spec changes.
Triggered by workos/openapi-spec@26ae9d6