fix(ui): fall back to promotional Bible attribution

[cameronapak]

Summary

• Use one attribution selector for BibleCard and BibleReader.
• Prefer nonblank copyright, then fall back to nonblank promotional content.
• Render attribution as text and preserve existing missing-attribution behavior.

Why

BibleCard and BibleReader could omit available attribution for versions without copyright text.

Impact

Consumers now see available attribution for the selected Bible version in both UI components.

Verification

• UI unit suite: 520 tests passed
• Focused BibleCard and BibleReader suite: 54 tests passed
• UI typecheck, lint, and build passed

Amp thread: https://ampcode.com/threads/T-01a11267-f18f-7245-9247-87604d8328ae

Confidence Score: 5/5

The PR appears safe to merge; no blocking issues remain.

What we checked:

• Missing attribution still fails: The helper returns null, but getPassageDisplay checks that result and throws MissingPassageAttributionError before returning.
• Attribution stays plain text: Both components place attribution inside React text expressions, so markup in the attribution is shown as text.

Summary

BibleCard and BibleReader now share the core attribution selector. They prefer nonblank copyright, then fall back to promotional content.

• Attribution remains plain text.
• getPassageDisplay still rejects missing attribution.
• The previous unnumbered test-layout finding is fixed: the added card tests are now top-level.
• No new actionable issues were found. Tests and builds were not run during this review.

_{Reviews (3) · Last reviewed commit: "feat(core): share passage attribution se..." · Reviewed by Greptile}

[changeset-bot]

🦋 Changeset detected

Latest commit: 2c2db21

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@youversion/platform-core	Minor
@youversion/platform-react-ui	Minor
@youversion/platform-react-hooks	Minor
vite-react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[bmanquen]

Review against YPE-6084. The BibleCard fallback is correct and matches core's precedence. One thing need to change before merge; both are marked (blocking) inline.

1. The new UI helper copies getPassageAttribution from core instead of reusing it.