Repository navigation
gh-15729: Animate library folders on their first expand - #15899
Merged
mr-cheffy merged 4 commits intoOct 13, 2026
Merged
Conversation
mr-cheffy
approved these changes
Oct 13, 2026
mr-cheffy
left a comment
mr-cheffy
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks! I've also removed startup timeout since it would now be fixed with this change as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15729
Copies of collapsed folders in the library's spaces section are built already collapsed, so their tabs are hidden but
.zen-tab-group-startnever gets the negativemargin-topthat collapsing leaves on a real folder. The first expand then animates that margin from 0 to 0 and the tabs pop in. Once the copy has been collapsed it has the offset, which is why only the first expand was off.animateExpand()now measures and applies the offset itself when it un-hides a container that doesn't have one, so the slide starts from the right place.Added
browser_library_folder_first_expand.js, which expands the copy of a collapsed folder in the library and checks the margin animation starts below 0. It fails on dev and passes with this change. Tested on a macOS arm64 build, andzen/tests/library,zen/tests/foldersandzen/tests/live-foldersgive the same results with and without it.