Add Azure Compute Gallery soft-delete and restore support - #30221
Draft
Haider Agha (haagha) with Copilot wants to merge 3 commits into
Draft
Haider Agha (haagha) with Copilot wants to merge 3 commits into
Haider Agha (haagha) with Copilot wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
Azure Pipelines: Successfully started running 2 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: haagha <64601174+haagha@users.noreply.github.com>
Co-authored-by: haagha <64601174+haagha@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add cmdlet syntax for Azure Compute Gallery image version soft delete
Add Azure Compute Gallery soft-delete and restore support
Sep 29, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The scenario fails parameter binding, lacks playback data, and the generated SDK and help surfaces are inconsistent.
Review effort: Balanced
Findings: 2
Open (5)
Comment on lines
+152
to
+154
| [Fact] | ||
| [Trait(Category.AcceptanceType, Category.CheckIn)] | ||
| public void TestGalleryImageVersionSoftDelete() |
|
|
||
| # Restore the soft-deleted image version | ||
| Restore-AzGalleryImageVersion -ResourceGroupName $rgname -GalleryName $galleryName ` | ||
| -GalleryImageDefinitionName $galleryImageName -Name $galleryImageVersionName -Location $loc; |
| } | ||
|
|
||
| string apiVersion = "2025-12-03"; | ||
| string apiVersion = "2026-03-03"; |
Comment on lines
+22
to
+25
| ### ResourceIdParameter | ||
| ``` | ||
| Get-AzGallerySoftDeletedImageVersion [-GalleryImageDefinitionResourceId] <String> | ||
| [-DefaultProfile <IAzureContextContainer>] [<CommonParameters>] |
Comment on lines
+15
to
+18
| ### DefaultParameter (Default) | ||
| ``` | ||
| Restore-AzGalleryImageVersion -ResourceGroupName <String> -GalleryName <String> | ||
| -GalleryImageDefinitionName <String> -Name <String> -Location <String> [-AsJob] |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The restore request omits the required restore marker, read operations remain on the older API contract, and several public help/model surfaces are inconsistent or incomplete.
Review effort: Balanced
Findings: 3
Open (11)
Comment on lines
+46
to
+49
| GalleryImageVersion galleryImageVersion = new GalleryImageVersion | ||
| { | ||
| Location = this.Location | ||
| }; |
| } | ||
| } | ||
| string apiVersion = "2025-12-03"; | ||
| string apiVersion = "2026-03-03"; |
| public GalleryImageVersionStorageProfile StorageProfile { get; set; } | ||
| public ReplicationStatus ReplicationStatus { get; set; } | ||
| public GalleryImageVersionSafetyProfile SafetyProfile { get; set; } | ||
| public bool? Restore { get; set; } |
| [-Description <String>] [-Tag <Hashtable>] [-Permission <String>] [-PublisherUri <String>] | ||
| [-PublisherContact <String>] [-Eula <String>] [-PublicNamePrefix <String>] | ||
| [-EnableSystemAssignedIdentity] [-UserAssignedIdentity <String[]>] | ||
| [-EnableSystemAssignedIdentity] [-UserAssignedIdentity <String[]>] [-EnableSoftDelete] [-DisableSoftDelete] [-SoftDeleteRetentionPeriodInDays <Int32>] [-SoftDeleteGracePeriodInDays <Int32>] |
|
|
||
| ### Example 2 | ||
| ```powershell | ||
| Restore-AzGalleryImageVersion -ResourceGroupName $rgname -GalleryName $galleryName -GalleryImageDefinitionName $imageName -Name "1.0.0" -Location $loc |
| [-PublisherUri <String>] [-PublisherContact <String>] [-Eula <String>] [-PublicNamePrefix <String>] | ||
| [-EnableSystemAssignedIdentity] [-DisableSystemAssignedIdentity] | ||
| [-UserAssignedIdentity <String[]>] [-RemoveUserAssignedIdentity <String[]>] | ||
| [-EnableSoftDelete] [-DisableSoftDelete] [-SoftDeleteRetentionPeriodInDays <Int32>] [-SoftDeleteGracePeriodInDays <Int32>] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Azure Compute Gallery soft-delete policy management, recycle-bin discovery, restoration, and permanent deletion bypass support for API version
2026-03-03.-EnableSoftDelete,-DisableSoftDelete, retention, and grace-period parameters.Get-AzGallerySoftDeletedImageVersion.Restore-AzGalleryImageVersionwith mandatory original home-region-Location.Remove-AzGalleryImageVersion -BypassSoftDeletefor irreversible deletion.ConsumptionEndTimeandImageState.PSGallerySoftDeletedImageVersionobjects.Verification Checklist