Skip to content

Add Azure Compute Gallery soft-delete and restore support #30221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
+1,134 −50
Draft

Add Azure Compute Gallery soft-delete and restore support #30221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b7558f
Initial plan
Copilot Sep 29, 2026
6a5f82f
Complete gallery soft delete contract
Copilot Sep 29, 2026
4eced18
Finalize gallery soft delete implementation
Copilot Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Compute/Compute.Management.Sdk/Generated/GalleriesOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -856,7 +856,7 @@ internal GalleriesOperations (ComputeManagementClient client)
throw new Microsoft.Rest.ValidationException(Microsoft.Rest.ValidationRules.Pattern, "galleryName", "^[^_\\W][\\w-._]{0,79}(?<![-.])$");
}
}
string apiVersion = "2025-12-03";
string apiVersion = "2026-03-03";
// Tracing
bool _shouldTrace = Microsoft.Rest.ServiceClientTracing.IsEnabled;
string _invocationId = null;
Expand Down Expand Up @@ -1151,7 +1151,7 @@ internal GalleriesOperations (ComputeManagementClient client)
throw new Microsoft.Rest.ValidationException(Microsoft.Rest.ValidationRules.Pattern, "galleryName", "^[^_\\W][\\w-._]{0,79}(?<![-.])$");
}
}
string apiVersion = "2025-12-03";
string apiVersion = "2026-03-03";
// Tracing
bool _shouldTrace = Microsoft.Rest.ServiceClientTracing.IsEnabled;
string _invocationId = null;
Expand Down
31 changes: 25 additions & 6 deletions src/Compute/Compute.Management.Sdk/Generated/GalleryImageVersionsOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,16 +619,23 @@ internal GalleryImageVersionsOperations (ComputeManagementClient client)
/// <param name='galleryImageVersionName'>
/// The name of the gallery image version to be retrieved.
/// </param>
/// <param name='bypassSoftDelete'>
/// Specifies whether to bypass the gallery's soft-delete policy and
/// permanently delete the gallery image version. If true, the version is
/// not retained in the recycle bin and cannot be restored. If false or
/// omitted, the version is soft-deleted when the gallery's soft-delete
/// policy is enabled and permanently deleted when the policy is disabled.
/// </param>
/// <param name='customHeaders'>
/// Headers that will be added to request.
/// </param>
/// <param name='cancellationToken'>
/// The cancellation token.
/// </param>
public async System.Threading.Tasks.Task<Microsoft.Rest.Azure.AzureOperationResponse> DeleteWithHttpMessagesAsync(string resourceGroupName, string galleryName, string galleryImageName, string galleryImageVersionName, System.Collections.Generic.Dictionary<string, System.Collections.Generic.List<string>> customHeaders = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken))
public async System.Threading.Tasks.Task<Microsoft.Rest.Azure.AzureOperationResponse> DeleteWithHttpMessagesAsync(string resourceGroupName, string galleryName, string galleryImageName, string galleryImageVersionName, bool? bypassSoftDelete = default(bool?), System.Collections.Generic.Dictionary<string, System.Collections.Generic.List<string>> customHeaders = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken))
{
// Send Request
Microsoft.Rest.Azure.AzureOperationResponse _response = await BeginDeleteWithHttpMessagesAsync(resourceGroupName, galleryName, galleryImageName, galleryImageVersionName, customHeaders, cancellationToken).ConfigureAwait(false);
Microsoft.Rest.Azure.AzureOperationResponse _response = await BeginDeleteWithHttpMessagesAsync(resourceGroupName, galleryName, galleryImageName, galleryImageVersionName, bypassSoftDelete, customHeaders, cancellationToken).ConfigureAwait(false);
return await this.Client.GetPostOrDeleteOperationResultAsync(_response, customHeaders, cancellationToken).ConfigureAwait(false);
}

Expand Down Expand Up @@ -733,7 +740,7 @@ internal GalleryImageVersionsOperations (ComputeManagementClient client)
throw new Microsoft.Rest.ValidationException(Microsoft.Rest.ValidationRules.CannotBeNull, "galleryImageVersionName");
}

string apiVersion = "2025-12-03";
string apiVersion = "2026-03-03";
// Tracing
bool _shouldTrace = Microsoft.Rest.ServiceClientTracing.IsEnabled;
string _invocationId = null;
Expand Down Expand Up @@ -1048,7 +1055,7 @@ internal GalleryImageVersionsOperations (ComputeManagementClient client)
throw new Microsoft.Rest.ValidationException(Microsoft.Rest.ValidationRules.CannotBeNull, "galleryImageVersionName");
}

string apiVersion = "2025-12-03";
string apiVersion = "2026-03-03";
// Tracing
bool _shouldTrace = Microsoft.Rest.ServiceClientTracing.IsEnabled;
string _invocationId = null;
Expand Down Expand Up @@ -1246,6 +1253,13 @@ internal GalleryImageVersionsOperations (ComputeManagementClient client)
/// <param name='galleryImageVersionName'>
/// The name of the gallery image version to be retrieved.
/// </param>
/// <param name='bypassSoftDelete'>
/// Specifies whether to bypass the gallery's soft-delete policy and
/// permanently delete the gallery image version. If true, the version is
/// not retained in the recycle bin and cannot be restored. If false or
/// omitted, the version is soft-deleted when the gallery's soft-delete
/// policy is enabled and permanently deleted when the policy is disabled.
/// </param>
/// <param name='customHeaders'>
/// Headers that will be added to request.
/// </param>
Expand All @@ -1264,7 +1278,7 @@ internal GalleryImageVersionsOperations (ComputeManagementClient client)
/// <return>
/// A response object containing the response body and response headers.
/// </return>
public async System.Threading.Tasks.Task<Microsoft.Rest.Azure.AzureOperationResponse> BeginDeleteWithHttpMessagesAsync(string resourceGroupName, string galleryName, string galleryImageName, string galleryImageVersionName, System.Collections.Generic.Dictionary<string, System.Collections.Generic.List<string>> customHeaders = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken))
public async System.Threading.Tasks.Task<Microsoft.Rest.Azure.AzureOperationResponse> BeginDeleteWithHttpMessagesAsync(string resourceGroupName, string galleryName, string galleryImageName, string galleryImageVersionName, bool? bypassSoftDelete = default(bool?), System.Collections.Generic.Dictionary<string, System.Collections.Generic.List<string>> customHeaders = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken))
{


Expand Down Expand Up @@ -1317,7 +1331,7 @@ internal GalleryImageVersionsOperations (ComputeManagementClient client)
throw new Microsoft.Rest.ValidationException(Microsoft.Rest.ValidationRules.CannotBeNull, "galleryImageVersionName");
}

string apiVersion = "2025-12-03";
string apiVersion = "2026-03-03";
// Tracing
bool _shouldTrace = Microsoft.Rest.ServiceClientTracing.IsEnabled;
string _invocationId = null;
Expand All @@ -1330,6 +1344,7 @@ internal GalleryImageVersionsOperations (ComputeManagementClient client)
tracingParameters.Add("galleryName", galleryName);
tracingParameters.Add("galleryImageName", galleryImageName);
tracingParameters.Add("galleryImageVersionName", galleryImageVersionName);
tracingParameters.Add("bypassSoftDelete", bypassSoftDelete);


tracingParameters.Add("cancellationToken", cancellationToken);
Expand All @@ -1350,6 +1365,10 @@ internal GalleryImageVersionsOperations (ComputeManagementClient client)
{
_queryParameters.Add(string.Format("api-version={0}", System.Uri.EscapeDataString(apiVersion)));
}
if (bypassSoftDelete != null)
{
_queryParameters.Add(string.Format("bypassSoftDelete={0}", System.Uri.EscapeDataString(Microsoft.Rest.Serialization.SafeJsonConvert.SerializeObject(bypassSoftDelete, this.Client.SerializationSettings).Trim('"'))));
}
if (_queryParameters.Count > 0)
{
_url += (_url.Contains("?") ? "&" : "?") + string.Join("&", _queryParameters);
Expand Down
44 changes: 36 additions & 8 deletions src/Compute/Compute.Management.Sdk/Generated/GalleryImageVersionsOperationsExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,9 +234,16 @@ public static GalleryImageVersion Update(this IGalleryImageVersionsOperations op
/// <param name='galleryImageVersionName'>
/// The name of the gallery image version to be retrieved.
/// </param>
public static void Delete(this IGalleryImageVersionsOperations operations, string resourceGroupName, string galleryName, string galleryImageName, string galleryImageVersionName)
/// <param name='bypassSoftDelete'>
/// Specifies whether to bypass the gallery's soft-delete policy and
/// permanently delete the gallery image version. If true, the version is
/// not retained in the recycle bin and cannot be restored. If false or
/// omitted, the version is soft-deleted when the gallery's soft-delete
/// policy is enabled and permanently deleted when the policy is disabled.
/// </param>
public static void Delete(this IGalleryImageVersionsOperations operations, string resourceGroupName, string galleryName, string galleryImageName, string galleryImageVersionName, bool? bypassSoftDelete = default(bool?))
{
((IGalleryImageVersionsOperations)operations).DeleteAsync(resourceGroupName, galleryName, galleryImageName, galleryImageVersionName).GetAwaiter().GetResult();
((IGalleryImageVersionsOperations)operations).DeleteAsync(resourceGroupName, galleryName, galleryImageName, galleryImageVersionName, bypassSoftDelete).GetAwaiter().GetResult();
}

/// <summary>
Expand All @@ -257,12 +264,19 @@ public static void Delete(this IGalleryImageVersionsOperations operations, strin
/// <param name='galleryImageVersionName'>
/// The name of the gallery image version to be retrieved.
/// </param>
/// <param name='bypassSoftDelete'>
/// Specifies whether to bypass the gallery's soft-delete policy and
/// permanently delete the gallery image version. If true, the version is
/// not retained in the recycle bin and cannot be restored. If false or
/// omitted, the version is soft-deleted when the gallery's soft-delete
/// policy is enabled and permanently deleted when the policy is disabled.
/// </param>
/// <param name='cancellationToken'>
/// The cancellation token.
/// </param>
public static async System.Threading.Tasks.Task DeleteAsync(this IGalleryImageVersionsOperations operations, string resourceGroupName, string galleryName, string galleryImageName, string galleryImageVersionName, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken))
public static async System.Threading.Tasks.Task DeleteAsync(this IGalleryImageVersionsOperations operations, string resourceGroupName, string galleryName, string galleryImageName, string galleryImageVersionName, bool? bypassSoftDelete = default(bool?), System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken))
{
(await operations.DeleteWithHttpMessagesAsync(resourceGroupName, galleryName, galleryImageName, galleryImageVersionName, null, cancellationToken).ConfigureAwait(false)).Dispose();
(await operations.DeleteWithHttpMessagesAsync(resourceGroupName, galleryName, galleryImageName, galleryImageVersionName, bypassSoftDelete, null, cancellationToken).ConfigureAwait(false)).Dispose();
}
/// <summary>
/// Create or update a gallery image version.
Expand Down Expand Up @@ -384,9 +398,16 @@ public static GalleryImageVersion BeginUpdate(this IGalleryImageVersionsOperatio
/// <param name='galleryImageVersionName'>
/// The name of the gallery image version to be retrieved.
/// </param>
public static void BeginDelete(this IGalleryImageVersionsOperations operations, string resourceGroupName, string galleryName, string galleryImageName, string galleryImageVersionName)
/// <param name='bypassSoftDelete'>
/// Specifies whether to bypass the gallery's soft-delete policy and
/// permanently delete the gallery image version. If true, the version is
/// not retained in the recycle bin and cannot be restored. If false or
/// omitted, the version is soft-deleted when the gallery's soft-delete
/// policy is enabled and permanently deleted when the policy is disabled.
/// </param>
public static void BeginDelete(this IGalleryImageVersionsOperations operations, string resourceGroupName, string galleryName, string galleryImageName, string galleryImageVersionName, bool? bypassSoftDelete = default(bool?))
{
((IGalleryImageVersionsOperations)operations).BeginDeleteAsync(resourceGroupName, galleryName, galleryImageName, galleryImageVersionName).GetAwaiter().GetResult();
((IGalleryImageVersionsOperations)operations).BeginDeleteAsync(resourceGroupName, galleryName, galleryImageName, galleryImageVersionName, bypassSoftDelete).GetAwaiter().GetResult();
}

/// <summary>
Expand All @@ -407,12 +428,19 @@ public static void BeginDelete(this IGalleryImageVersionsOperations operations,
/// <param name='galleryImageVersionName'>
/// The name of the gallery image version to be retrieved.
/// </param>
/// <param name='bypassSoftDelete'>
/// Specifies whether to bypass the gallery's soft-delete policy and
/// permanently delete the gallery image version. If true, the version is
/// not retained in the recycle bin and cannot be restored. If false or
/// omitted, the version is soft-deleted when the gallery's soft-delete
/// policy is enabled and permanently deleted when the policy is disabled.
/// </param>
/// <param name='cancellationToken'>
/// The cancellation token.
/// </param>
public static async System.Threading.Tasks.Task BeginDeleteAsync(this IGalleryImageVersionsOperations operations, string resourceGroupName, string galleryName, string galleryImageName, string galleryImageVersionName, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken))
public static async System.Threading.Tasks.Task BeginDeleteAsync(this IGalleryImageVersionsOperations operations, string resourceGroupName, string galleryName, string galleryImageName, string galleryImageVersionName, bool? bypassSoftDelete = default(bool?), System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken))
{
(await operations.BeginDeleteWithHttpMessagesAsync(resourceGroupName, galleryName, galleryImageName, galleryImageVersionName, null, cancellationToken).ConfigureAwait(false)).Dispose();
(await operations.BeginDeleteWithHttpMessagesAsync(resourceGroupName, galleryName, galleryImageName, galleryImageVersionName, bypassSoftDelete, null, cancellationToken).ConfigureAwait(false)).Dispose();
}
/// <summary>
/// List gallery image versions in a gallery image definition.
Expand Down
18 changes: 16 additions & 2 deletions src/Compute/Compute.Management.Sdk/Generated/IGalleryImageVersionsOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,13 @@ public partial interface IGalleryImageVersionsOperations
/// <param name='galleryImageVersionName'>
/// The name of the gallery image version to be retrieved.
/// </param>
/// <param name='bypassSoftDelete'>
/// Specifies whether to bypass the gallery's soft-delete policy and
/// permanently delete the gallery image version. If true, the version is
/// not retained in the recycle bin and cannot be restored. If false or
/// omitted, the version is soft-deleted when the gallery's soft-delete
/// policy is enabled and permanently deleted when the policy is disabled.
/// </param>
/// <param name='customHeaders'>
/// The headers that will be added to request.
/// </param>
Expand All @@ -175,7 +182,7 @@ public partial interface IGalleryImageVersionsOperations
/// <exception cref="Microsoft.Rest.Azure.CloudException">
/// Thrown when the operation returned an invalid status code
/// </exception>
System.Threading.Tasks.Task<Microsoft.Rest.Azure.AzureOperationResponse> DeleteWithHttpMessagesAsync(string resourceGroupName, string galleryName, string galleryImageName, string galleryImageVersionName, System.Collections.Generic.Dictionary<string, System.Collections.Generic.List<string>> customHeaders = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken));
System.Threading.Tasks.Task<Microsoft.Rest.Azure.AzureOperationResponse> DeleteWithHttpMessagesAsync(string resourceGroupName, string galleryName, string galleryImageName, string galleryImageVersionName, bool? bypassSoftDelete = default(bool?), System.Collections.Generic.Dictionary<string, System.Collections.Generic.List<string>> customHeaders = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken));

/// <summary>
/// Create or update a gallery image version.
Expand Down Expand Up @@ -266,6 +273,13 @@ public partial interface IGalleryImageVersionsOperations
/// <param name='galleryImageVersionName'>
/// The name of the gallery image version to be retrieved.
/// </param>
/// <param name='bypassSoftDelete'>
/// Specifies whether to bypass the gallery's soft-delete policy and
/// permanently delete the gallery image version. If true, the version is
/// not retained in the recycle bin and cannot be restored. If false or
/// omitted, the version is soft-deleted when the gallery's soft-delete
/// policy is enabled and permanently deleted when the policy is disabled.
/// </param>
/// <param name='customHeaders'>
/// The headers that will be added to request.
/// </param>
Expand All @@ -275,7 +289,7 @@ public partial interface IGalleryImageVersionsOperations
/// <exception cref="Microsoft.Rest.Azure.CloudException">
/// Thrown when the operation returned an invalid status code
/// </exception>
System.Threading.Tasks.Task<Microsoft.Rest.Azure.AzureOperationResponse> BeginDeleteWithHttpMessagesAsync(string resourceGroupName, string galleryName, string galleryImageName, string galleryImageVersionName, System.Collections.Generic.Dictionary<string, System.Collections.Generic.List<string>> customHeaders = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken));
System.Threading.Tasks.Task<Microsoft.Rest.Azure.AzureOperationResponse> BeginDeleteWithHttpMessagesAsync(string resourceGroupName, string galleryName, string galleryImageName, string galleryImageVersionName, bool? bypassSoftDelete = default(bool?), System.Collections.Generic.Dictionary<string, System.Collections.Generic.List<string>> customHeaders = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken));

/// <summary>
/// List gallery image versions in a gallery image definition.
Expand Down
Loading
Loading